cvs commit: ports/Mk bsd.port.mk bsd.port.subdir.mk bsd.xorg.mk

[Pav Lucistnik]

Alexander Leidinger píše v st 12. 03. 2008 v 11:04 +0100:
> Quoting Pav Lucistnik <pav at FreeBSD.org> (from Tue, 11 Mar 2008  
> 23:45:04 +0000 (UTC)):
> 
> >   - Teach USE_LDCONFIG to do the right thing when used with USE_LINUX_PREFIX
> >
> >   PR:             ports/118212    
> > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=118212
> >   Original patch: vd
> >   Patch by:       pav
> 
> I would like to know why emulation@ was not in the loop for this.
> 
> At
> http://www.leidinger.net/FreeBSD/port-patches/Mk:bsd.port.mk.diff

I wasn't aware of this patch. Is it mentioned in a PR assigned to
portmgr anywhere?

If I ignore not-ldconfig related changes in your patch, the
functionality should be equivalent. I do not need to set
NO_LDCONFIG_MTREE, because that code branch is never reached.
My code goes like if (linux) { do linux stuff } else { do native stuff }
Your code went like if (linux) { setup some variables } else { setup
some variables} endif; do { common stuff }.

Only difference I see is that you condition the use of linux mdconfig by
presence of USE_LINUX, I need USE_LINUX_PREFIX, which is more strict, I
think.

-- 
Pav Lucistnik <pav at oook.cz>
              <pav at FreeBSD.org>

Just because you're an angel doesn't mean you have to be a fool.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
	=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
	=?ISO-8859-1?Q?_zpr=E1vy?=
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20080312/c5299df5/attachment-0001.pgp