cvs commit: ports/editors/codelite Makefile distinfo pkg-plist ports/editors/codelite/files patch-configure

Alexey Dokuchaev danfe at FreeBSD.org
Fri Jul 4 13:28:47 UTC 2008


On Thu, Jul 03, 2008 at 06:40:53PM +0000, Pietro Cerutti wrote:
> gahr        2008-07-03 18:40:53 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     editors/codelite     Makefile distinfo pkg-plist 
>     editors/codelite/files patch-configure 
>   Log:
>   - Update to 1.0

Some quick observations:

- You've left PORTREVISION, which is porbably unnecessary
- Bad indent of WRKSRC assignment
- Ditto for USE_WX
- You've dropped GNU_CONFIGURE, and instroduced custom do-configure
  target which pretty much mimics default action.  If configure script
  is not GNU autotools generated and one cannot assume it would
  understand some common options (--prefix et al.), there's
  HAS_CONFIGURE knob for that in bpm
- Most directories are created with mkdir, some with install -d, which
  introduces certain inconsistency
- Ditto for trailing slashes for target directory names during
  installation (also, in pkg-plist)
- (cd ${WRKSRC}/Runtime/sdk/include/UnitTest++ &&  ${COPYTREE_SHARE} \*
						 ^^
  superfluous space here ------------------------++

./danfe


More information about the cvs-all mailing list