cvs commit: src/sys/netinet sctp_timer.c sctp_timer.h

Giorgos Keramidas keramida at freebsd.org
Thu Aug 28 21:51:55 UTC 2008


On Thu, 28 Aug 2008 20:31:24 +0000 (UTC), Randall Stewart <rrs at freebsd.org> wrote:
> rrs         2008-08-28 20:31:24 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/netinet          sctp_timer.c sctp_timer.h 
>   Log:
>   SVN rev 182405 on 2008-08-28 20:31:24Z by rrs
>   
>   ok, non static the function and put in the .h so
>   when we do INVARANT compile the compiler will not
>   dis the function that is not used. Hmm maybe I should have
>   made it ifndef INVARIANTs..

gcc should be smart enough to throw away the non-static function
if SCTP is built into the kernel (and not as a module) *and*
there are no external references from other parts of the source.
So this should work fine.

The ifndef INVARIANTS version is probably something like the
second patch I sent earlier, also at
http://people.freebsd.org/~keramida/diff/sctp-timer-20080828-02.patch

but I didn't really 'like' having a static function inside a
large #ifndef INVARIANTS block...

Thanks for fixing this so fast :-)



More information about the cvs-all mailing list