cvs commit: src/sbin/fsck_ffs main.c
jhb at freebsd.org
Sat Aug 23 03:32:28 UTC 2008
On Friday 22 August 2008 09:21:10 pm Craig Rodrigues wrote:
> rodrigc 2008-08-23 01:21:10 UTC
> FreeBSD src repository
> Modified files:
> sbin/fsck_ffs main.c
> SVN rev 182027 on 2008-08-23 01:21:10Z by rodrigc
> Instead of passing MNT_UPDATE, MNT_SNAPSHOT, MNT_RELOAD from
> userspace to kernel via nmount(), pass in the strings
> "update", "snapshot", "reload".
> We want to move away from passing MNT_ flags from userspace -> kernel
> via nmount(), and instead favor passing the string options.
> Revision Changes Path
> 1.53 +3 -2 src/sbin/fsck_ffs/main.c
Hmm, one thing that I've mentioned to you before though is that some options
(like update) aren't mount options, they are flags to the mount() syscall
that explain how to apply the list of options. Those sort of flags don't
really belong in the mount options list it seems to be, but in a
separate "flags" argument to nmount() itself.
That would also remove the need for having the kernel weed out these options
(force/update/etc.) from the mount options list by not having them there in
the first place. I think having mount operation flags passed separately from
mount options is going to be a less bug-prone and more stable approach.
More information about the cvs-all