cvs commit: ports/games/secretmaryochronicles-music Makefile

[Joe Marcus Clarke]

On Sun, 2008-08-10 at 22:22 -0700, Adam Weinberger wrote:
> >> (08.10.2008 @ 2159 PST): Joe Marcus Clarke said, in 2.4K: <<
> > On Sun, 2008-08-10 at 21:48 -0700, Adam Weinberger wrote:
> > > >> (08.10.2008 @ 2136 PST): Joe Marcus Clarke said, in 1.8K: <<
> > > > On Sun, 2008-08-10 at 21:15 -0700, Adam Weinberger wrote:
> > > > > >> (08.10.2008 @ 1911 PST): QA Tindy said, in 4.0K: <<
> > > > > > 
> > > > > > ===>   Registering installation for secretmaryochronicles-music-4.0  
> > > > > > Creating bzip'd tar ball in '/tmp/packages/All/secretmaryochronicles-music-4.0.tbz'
> > > > > > Deleting secretmaryochronicles-music-4.0
> > > > > > 
> > > > > > === Checking filesystem state
> > > > > > list of extra files and directories in / (not present before this port was installed but present after it was deinstalled)
> > > > > > 7113692        4 drwxr-xr-x    2 root             wheel                 512 Aug 10 22:55 usr/local/share/smc/music
> > > > > > ================================================================
> > > > > > build of /usr/ports/games/secretmaryochronicles-music ended at Sun Aug 10 22:55:31 UTC 2008
> > > > > > 
> > > > > >> end of "Re: cvs commit: ports/games/secretmaryochronicles-music Makefile" from QA Tindy <<
> > > > > 
> > > > > Is there something in particular that I'm missing here? That directory
> > > > > is created by a dependent port (games/secretmaryochronicles).
> > > > 
> > > > games/secretmaryochronicles is missing the following in pkg-plist:
> > > > 
> > > > @exec mkdir -p %D/share/smc/music
> > > > 
> > > > Joe
> > > >> end of "Re: cvs commit: ports/games/secretmaryochronicles-music Makefile" from Joe Marcus Clarke <<
> > > 
> > > At least on my machine, that directory is created by the install
> > > process...
> > 
> > During the PORT install process, not the PACKAGE install process.  The
> > latter is what is used when building secretmaryocrhonicles-music, and it
> > is the reason the directory isn't created before
> > secretmaryochronicles-music is installed.
> > 
> >> end of "Re: cvs commit: ports/games/secretmaryochronicles-music Makefile" from Joe Marcus Clarke <<
> 
> Seems odd that a directory created by the games/secretmaryochronicles
> port install process wouldn't be part of the package that's made of it,
> unless the package thinger doesn't pick up empty directories. But, I'll
> take your word for it. I've poked the maintainer to make the change.

It doesn't.  Empty directories must be manually created in the plist or
in a pkg-install script.  See sysutils/consolekit for a few examples.

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20080811/b903be6c/attachment.pgp