cvs commit: src/sys/dev/io iodev.c

Ed Schouten ed at
Fri Aug 8 13:44:06 UTC 2008

ed          2008-08-08 13:43:56 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/io           iodev.c 
  SVN rev 181428 on 2008-08-08 13:43:56Z by ed
  Remove D_NEEDGIANT from io(4).
  There is no need to mark this device node to use Giant. The only
  architectures that use io(4) (i386 and amd64) only change a flag in
  td->td_frame, which is only accessed by curthread.
  Apart from this change, I think some fishy things may happen when using
  /dev/io in multithreaded applications. I haven't tested, but looking at
  the code, the flag doesn't get cleared when close() is called from
  another thread, but this may not be this important.
  I'm not removing D_NEEDGIANT from mem(4), because this driver isn't
  Giant safe at all (it calls GIANT_REQUIRED).
  Revision  Changes    Path
  1.4       +0 -1      src/sys/dev/io/iodev.c

More information about the cvs-all mailing list