cvs commit: src/sys/arm/at91 at91_twi.c src/sys/arm/xscale/ixp425 ixp425_iic.c src/sys/dev/bktr bktr_i2c.c src/sys/dev/iicbus iicbb.c src/sys/dev/pcf envctrl.c pcf.c pcf_ebus.c pcf_isa.c pcfvar.h src/sys/dev/ppbus lpbb.c src/sys/pci viapm.c

John Baldwin jhb at
Mon Aug 4 20:47:18 UTC 2008

jhb         2008-08-04 20:46:15 UTC

  FreeBSD src repository

  Modified files:
    sys/arm/at91         at91_twi.c 
    sys/arm/xscale/ixp425 ixp425_iic.c 
    sys/dev/bktr         bktr_i2c.c 
    sys/dev/iicbus       iicbb.c 
    sys/dev/pcf          envctrl.c pcf.c pcf_ebus.c pcf_isa.c 
    sys/dev/ppbus        lpbb.c 
    sys/pci              viapm.c 
  SVN rev 181303 on 2008-08-04 20:46:15Z by jhb
  Add locking to the various iicbus(4) bridge drivers:
  - Just grab Giant in the ixp425_iic(4) driver since this driver uses
    a shared address/data register window pair to access the actual
    I2C registers.  None of the other ixp425 drivers lock access to these
    shared address/data registers yet and that would need to be done before
    this could use any meaningful locking.
  - Add locking to the interrupt handler and 'iicbus_reset' methods of the
    at91_twi(4) driver.
  - Add locking to the pcf(4) driver.  Other pcf(4) fixes include:
    - Don't needlessly zero the softc.
    - Use bus_foo rather than bus_space_foo and remove bus space tag and
      handle from softc.
  - The lpbb(4) driver just grabs Giant for now.  This will be refined later
    when ppbus(4) is locked.
  - As was done with smbus earlier, move the DRIVER_MODULE() lines to match
    the bus driver (either iicbus or iicbb) to the bridge driver into the
    bridge drivers.
  Tested by:      sam (arm/ixp425)
  Revision  Changes    Path
  1.12      +7 -0      src/sys/arm/at91/at91_twi.c
  1.3       +9 -0      src/sys/arm/xscale/ixp425/ixp425_iic.c
  1.31      +1 -0      src/sys/dev/bktr/bktr_i2c.c
  1.20      +1 -10     src/sys/dev/iicbus/iicbb.c
  1.9       +8 -5      src/sys/dev/pcf/envctrl.c
  1.26      +48 -15    src/sys/dev/pcf/pcf.c
  1.8       +6 -4      src/sys/dev/pcf/pcf_ebus.c
  1.10      +6 -4      src/sys/dev/pcf/pcf_isa.c
  1.4       +14 -6     src/sys/dev/pcf/pcfvar.h
  1.20      +41 -13    src/sys/dev/ppbus/lpbb.c
  1.21      +1 -0      src/sys/pci/viapm.c

More information about the cvs-all mailing list