cvs commit: src/lib/libufs type.c

[Ceri Davies]

On Fri, Mar 16, 2007 at 12:51:57PM +0100, Pawel Jakub Dawidek wrote:
> On Fri, Mar 16, 2007 at 11:16:12AM +0000, Ceri Davies wrote:
> > On Fri, Mar 16, 2007 at 03:13:29AM +0000, Pawel Jakub Dawidek wrote:
> > > pjd         2007-03-16 03:13:29 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     lib/libufs           type.c 
> > >   Log:
> > >   The ufs_disk_fillout(3) can take special device name (with or without /dev/
> > >   prefix) as an argument and mount point path. At the end it has to find
> > >   device name file system is stored on, which means when mount point path is
> > >   given, it tries to look into /etc/fstab and find special device
> > >   corresponding to the given mount point. This is not perfect, because it
> > >   doesn't handle the case when file system is mounted by hand and mount point
> > >   is given as an argument.
> > >   
> > >   I found this problem while trying to use snapinfo(8), which passes mount
> > >   points to the ufs_disk_fillout(3) function, but I had file system mounted
> > >   manually, so snapinfo(8) was exiting with the error below:
> > >   
> > >           ufs_disk_fillout: No such file or directory
> > >   
> > >   I modified libufs(3) to handle those arguments (the order is important):
> > >   
> > >   1. special device with /dev/ prefix
> > >   2. special device without /dev/ prefix
> > >   3. mount point listed in /etc/fstab, directory exists
> > >   4. mount point listed in /etc/fstab, directory doesn't exist
> > >   5. mount point of a file system mounted by hand
> > 
> > Is there any chance that this, or the related snapinfo commit, fixes
> > PR 94635?
> 
> I'm quite sure this should be fixed now, yes. Can we ask submitter to
> retest?

Well that's me, so will do :)

Thanks,

Ceri
-- 
That must be wonderful!  I don't understand it at all.
                                                  -- Moliere
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20070316/75dad352/attachment.pgp