cvs commit: ports/devel/kdesvn Makefile distinfo pkg-plist

[Li-Wen Hsu]

On Fri, Jun 15, 2007 at 19:37:15 +0400, Andrew Pantyukhin wrote:
> > -MAINTAINER=    yuanjue at yuanjue.net
> > +MAINTAINER=    yuanjue at freebsd.org
> 
>  We have a policy of capitalizing our project's name as
>  "FreeBSD" where possible. From prior discussions, I
>  remember there might be some trademark issues involved,
>  and at least for some time after the new logo has been
>  accepted, some developers were quite sure it's not a
>  style issue, but rather a mandatory policy.

Thanks for notification.  Since this change is come from the PR, I'll
change it after approved by YUAN Jue.

> > +.if !defined(NOPORTDOCS)
> > +DOCSDIR=       ${PREFIX}/share/doc/HTML/en/kdesvn
> >  .endif
> 
>  Is there any merit to this DOCSDIR definition being
>  conditional?

Seems no.  Sometimes I put this in the Makefile:

.if !defined(NOPORTDOCS)
DOCSDIR=        /some/other/place
PORTDOCS=       *
.endif

This gives me a bad habit to write DOCSDIR definition like this, I'll be
aware next time.  Also, I'll change this after getting maintainer's
approval.

>  Thanks!

Thanks.

Besides, though I don't really care where the review goes. (I am very happy
with this)  But since some people don't like this.  How about replying the
commit in private, and maintaining a "Common Mistakes when Porting" list,
after a number of items collected?  Posting it to ports@ list and put into
the porter's handbook might be a good idea.  This can get more porters'
attention, and easier to find.  Sometimes, looking for something in the
high-traffic mailing list is quite hard.  After all, not everyone read
every commit message and its reply, but every should read the handbook
(and read again when it is updated), right?

Thanks for your comment, again.

-- 
Best Regards,
Li-Wen Hsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20070615/0343db4f/attachment.pgp