cvs commit: ports/net/ser Makefile ports/net/ser/files ser.in

[Doug Barton]

On Wed, 15 Aug 2007, Maxim Sobolev wrote:

> Doug Barton wrote:
>> 
>> On Wed, 15 Aug 2007, Maxim Sobolev wrote:
>> 
>>> sobomax     2007-08-15 18:35:05 UTC
>>>
>>>  FreeBSD ports repository
>>>
>>>  Modified files:
>>>    net/ser              Makefile
>>>  Added files:
>>>    net/ser/files        ser.in
>>>  Log:
>>>  Add startup script. Bump PORTREVISION.
>>>
>>>  Submitted by:   Blaz Zupan
>>>
>>>  Revision  Changes    Path
>>>  1.23      +2 -1      ports/net/ser/Makefile
>>>  1.1       +34 -0     ports/net/ser/files/ser.in (new)
>>> 
>>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/ser/Makefile.diff?&r1=1.22&r2=1.23&f=h 
>>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/ser/files/ser.in
>> 
>> Looks good overall. One nit, you need %%PREFIX%% instead of ${prefix}.
>
> Already there:
>
> prefix=%%PREFIX%%

That's my fault, I actually specifically looked for that and didn't find 
it.

That just changes my objection to "Pointless indirection of a one-time-use 
value." There is no reason for that to be a variable, it should just have 
%%PREFIX%% in the command= line.

Doug

-- 

     This .signature sanitized for your protection