cvs commit: src/sys/pci agp_i810.c

[Eric Anholt]

On Thu, 2006-09-28 at 09:22 +0200, Joel Dahl wrote:
> On Thu, 2006-09-28 at 08:12 +0200, Joel Dahl wrote:
> > On Wed, 2006-09-27 at 06:38 +0000, Eric Anholt wrote:
> > > anholt      2006-09-27 06:38:54 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/pci              agp_i810.c 
> > >   Log:
> > >   Add support for 945G/GM AGP chipsets.
> > >   
> > >   The key problem was that the aperture size detection using the MSAC bit
> > >   doesn't work -- the bit appears to be set even when it shouldn't be.  Linux
> > >   takes a different approach, testing for a bit of the GMADR (PCIR_BAR(2)) being
> > >   set.  However, as I don't think that's a safe way to test aperture size, we
> > >   just allocate the resource and check its size.  This also pointed out that
> > >   agp_generic_attach hadn't been allocating our aperture resource, which may
> > >   have caused problems in some cases.
> > >   
> > >   Also corrected is a minor copy-and-pasteo in an error case.
> > 
> > Hmm, I have a HP NX7400 laptop with an Intel i945 chipset, and it's
> > running a very fresh current (GENERIC, no changes made whatsoever).
> > However, I see the following in my dmesg when I start X (I *think* it
> > started appearing just after your commit to agp_i810.c):
> 
> Ok, I can confirm that reverting back to revision 1.38 of agp_i810.c
> fixes the problem.

Right, with no AGP support, you don't get DRM support, so you don't hit
the path in the DRM with the witness warning.  I'm not sure what to do
about that warning yet :/

-- 
Eric Anholt                             anholt at FreeBSD.org
eric at anholt.net                         eric.anholt at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20060929/f79ef34d/attachment.pgp