cvs commit: src/sys/dev/kbdmux kbdmux.c

[Maksim Yevmenkin]

Ruslan,

> > revision 1.12 does NOT work on sparc64. it causes crash with
> >
> > panic: trap: memory address not aligned
> >
> I was affraid of something like this, but given that an argument
> is 64-bit aligned, I didn't think it would be a real problem.
> Can you try removing the (int) casts in front of *(intptr_t *)
> and see if it helps?

nope, same crash. the only thing that seems to help is to reverting
back to (int *) cast just like other keyboard drivers do. then it
works.

i'm in the process of getting amd64 snapshot iso to try it on a couple
of boxes. if it will work then i'm going to back (int *) -> (intptr_t
*) changes introduced in rev 1.8.

thanks,
max

>
> > i'll try to find which particular ioctl causes it. in the mean time
> > reverting everything back to (int *) casting makes everything work.
> >
> > btw, other keyboard drivers ukbd(4), atkbd(4) and sunkbd(4) use simple
> > cast (int *) and NOT intptr_t.
> >
> > thanks,
> > max
> >
> > On 9/19/06, Ruslan Ermilov <ru at freebsd.org> wrote:
> > >ru          2006-09-19 13:03:10 UTC
> > >
> > >  FreeBSD src repository
> > >
> > >  Modified files:
> > >    sys/dev/kbdmux       kbdmux.c
> > >  Log:
> > >  Make typecast expressions comply with style(9).
> > >
> > >  Revision  Changes    Path
> > >  1.12      +5 -5      src/sys/dev/kbdmux/kbdmux.c
>
>
> Cheers,
> --
> Ruslan Ermilov
> ru at FreeBSD.org
> FreeBSD committer
>
>
>