cvs commit: src/sys/netinet in_pcb.c tcp_subr.c tcp_timer.c tcp_var.h

Mike Silbersack silby at silby.com
Mon Sep 11 22:21:17 PDT 2006


On Mon, 11 Sep 2006, Gleb Smirnoff wrote:

> The UMA zone can't be made smaller than it is, while IP port ranges
> can vary in both directions.

Hm, it can't be made smaller because we're using UMA_ZONE_NOFREE... why 
are we using that?  Shouldn't locking handle that, rwatson? :)

> I think that your original commit should be rethought. It should free one
> tcptw entry, in a case of absolute match, and return NULL. Do not jump
> up and go on into cycle again.

In order to do that, it has to know if the tcptw entry is one that will 
be useful for the upcoming connection.  It might have to scan through many 
entries before it comes upon an entry, as your tests proved.  It's still 
going to perform poorly in certain circumstances.

Mike "Silby" Silbersack


More information about the cvs-all mailing list