cvs commit: src/etc rc.subr

[Yar Tikhiy]

On Mon, Nov 27, 2006 at 01:34:56PM +0000, Florent Thoumie wrote:
> Yar Tikhiy wrote:
> > On Sun, Nov 26, 2006 at 07:03:20PM +0000, Florent Thoumie wrote:
> >> flz         2006-11-26 19:03:19 UTC
> >>
> >>   FreeBSD src repository
> >>
> >>   Modified files:
> >>     etc                  rc.subr 
> >>   Log:
> >>   Remove leading dollar sign in rcvar command output.
> >>   There's no dollar use in variable assignment in sh.
> >>   Assuming this is can be expected behavior for some
> >>   people, this change won't be MFC'ed to RELENG_6.
> >>   
> >>   Discussed with: yar on -rc
> >>   
> >>   Revision  Changes    Path
> >>   1.70      +2 -2      src/etc/rc.subr
> > 
> > Such one-character bogosities are an eyesore but they often take
> > enormous effort to be fixed because of complications they have.
> > It's no surprise they usually live forever.  Thanks for starting
> > the fight against this one!
> > 
> > By the way, now the output follows the NetBSD rc.conf style:
> > 
> > # $foo_enable
> > foo_enable=YES
> > 
> > Could it be changed even further to match our own rc.conf style?
> > I.e.:
> > 
> > # $foo_enable
> > foo_enable="YES"
> 
> Yeah, makes sense. There's also a patch in gnats to add a
> 'enable/disable' command to rc.subr. I'll try to have a look.

If integrating the latter patch, please make sure it handles all
places where rc.conf variables can be specified: the files listed
in ${rc_conf_files}, the files in /etc/rc.conf.d.  However, the
feature will hardly be robust to all possible tricks people can use
in rc.conf.  It's a shell script, after all.  I myself use built-in
shell commands in rc.conf in some cases, e.g., to have a single
rc.conf file for a group of redundant, mostly identical servers.

-- 
Yar