cvs commit: src/sys/netinet tcp_syncache.c

Gleb Smirnoff glebius at FreeBSD.org
Wed Feb 8 00:49:41 PST 2006


On Tue, Feb 07, 2006 at 07:59:46PM +0000, Qing Li wrote:
Q> qingli      2006-02-07 19:59:46 UTC
Q> 
Q>   FreeBSD src repository
Q> 
Q>   Modified files:
Q>     sys/netinet          tcp_syncache.c 
Q>   Log:
Q>   Fixes a crash due to the memory of the newly allocated syncache entry
Q>   in syncache_lookup() is not cleared and may lead to an arbitrary and
Q>   bogus rtentry pointer which later gets free'd.
Q>   
Q>   Reviewed by: andre
Q>   MFC after: 3 days

I think it will be better just pass M_ZERO flag to uma_zalloc(). Also,
do same in the second uma_zalloc() call in this file.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE


More information about the cvs-all mailing list