cvs commit: src/sys/kern subr_prf.c
    Robert Watson 
    rwatson at FreeBSD.org
       
    Mon Sep 26 04:31:33 PDT 2005
    
    
  
On Mon, 26 Sep 2005, Bruce Evans wrote:
>>  Acquire Giant in uprintf() and tprintf() rather than asserting it.  In
>>  the vast majority of cases, these functions are called without mutexes
>>  held, meaning that in all but two cases, there will be no ordering
>>  issues with doing this, and it will eliminate the need for changes in
>>  the caller.  In two cases, mutexes are held, so Giant must be acquired
>>  before those mutexes such that uprintf() and tprintf() recurse Giant
>>  rather than generating a lock order reversal.
>
> Thansks.
I'll take a jaunt through the rest of the tree removing the Giant 
acquisitions (in most cases) later this afternoon (local time)
Robert N M Watson
    
    
More information about the cvs-all
mailing list