cvs commit: ports/games/quake2lnx Makefile distinfo pkg-message pkg-plist ports/games/quake2lnx/files extra-patch-src_rogue_g__local.h extra-patch-src_rogue_q__shared.c extra-patch-src_xatrix_q__shared.c patch-Makefile patch-src::game::g_phys.c patch-src::linux::gl_glx.c patch-src::linux::rw_in_svgalib.c ...

[Kris Kennaway]

On Thu, Nov 17, 2005 at 01:54:27PM +0000, Alexey Dokuchaev wrote:
> On Thu, Nov 17, 2005 at 02:42:54PM +0100, Pav Lucistnik wrote:
> > Alexey Dokuchaev p??e v ?t 17. 11. 2005 v 13:31 +0000:
> > 
> > > >   PR:             ports/87181
> > > >   Submitted by:   Alejandro Pulver <alejandro at varnet.biz>
> > > >   Approved by:    maintainer timeout
> > > 
> > > Edwin,
> > > 
> > > I wish I could say "thanks" for work you've done, but I would appreciate
> > > private confirmation mail even in case of "maintainer timeout".  This is
> > > a complicated port, and such a change is potentially harmful due to its
> > > massiveness.  Commits like this should probably be done per-piece fashion,
> > > otherwise it's really hard to check if nothing got broken.  Not to
> > > mention that I actually disagree on the number of changes suggested in
> > > the PR (and committed by you).
> > > 
> > > I'm not asking for a backout, in fact I realize how annoying it can be
> > > when PR hangs in "open" state for a month(s), and I would have probably
> > > needed to change PR state to something like "working on it, please be
> > > patient", however, I must say I got somewhat frustrated to have to fix
> > > all those things that I don't like WRT this commit.
> > 
> > So why have you not handled the PR yourself? Is 36 days really not
> > enough to sort out a single port PR?
> 
> As I have said, proposed changes were pretty controversial, and I was in
> fact not sure whether I really wanted them in my port.  I *was* working
> on it, albeit rather time-sparsely, exchanged a few emails with submitter.
> I can tolerate "maintainer timeout" for really inactive committer, but
> not for someone doing commits and being active in the lists.
> 
> I'll go and shut up now, telling myself to take care of my ports faster
> next time.  :-)

All you needed to do was to either reply to the PR or mark it analyzed
so it was clear you were working on it.

Kris

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20051117/31b820e2/attachment.bin