cvs commit: src/etc/rc.d pf

Yar Tikhiy yar at FreeBSD.org
Tue Nov 8 13:42:42 PST 2005


On Thu, Nov 03, 2005 at 01:17:49PM +0000, Ralf S. Engelschall wrote:
> rse         2005-11-03 13:17:49 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc/rc.d             pf 
>   Log:
>   There is no need to explicitly add "status" to $extra_commands in
>   the /etc/rc.d/pf script as it is implicitly added by /etc/rc.subr's
>   run_rc_command() because of the existing $pf_program.
>   
>   Submitted by:   Christoph Schug <chris at schug.net>
>   MFC after:      1 week
>   
>   Revision  Changes    Path
>   1.11      +1 -1      src/etc/rc.d/pf

I'm afraid you were relying on evil side-effects of the variable being
named *_program.  Those side-effect have been eliminated since rc.subr
rev. 1.42.  Now "status" doesn't appear among rc.d/pf valid arguments:

	vpc7# sh /etc/rc.d/pf
	Usage: /etc/rc.d/pf [fast|force|one](start|stop|restart|rcvar|check|reload|resync)

I might be wrong, but it seems to me that your change to rc.d/pf
should be backed out.

The point is that the default "status" method is for rc.d scripts
that handle startup and shutdown of conventional daemons, and not
for custom tasks like the pf case.

-- 
Yar


More information about the cvs-all mailing list