cvs commit: src/sys/crypto/rijndael rijndael-alg-fst.c rijndael-alg-fst.h rijndael-api-fst.c rijndael-api-fst.h rijndael.h

[Sam Leffler]

Hajimu UMEMOTO wrote:
> ume         2005-03-11 16:26:10 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/crypto/rijndael  rijndael-alg-fst.c rijndael-api-fst.c 
>                          rijndael-api-fst.h rijndael.h 
>   Removed files:
>     sys/crypto/rijndael  rijndael-alg-fst.h 
>   Log:
>   integrate rijndael-alg-fst.h into rijndael.h.

Why did you make this change and others before I could respond?  I told 
you I agreed with your overall goal but that there were specific isuses 
we needed to resolve before you pulled the trigger.  Less than 24 hours 
after your last note to me you committed the changes.

This change in particular I'm not happy with because--as I explained to 
you--I am uncertain if there are user applications that include files 
from /usr/include/crypto that may be affected.

As we discussed privately there is no immediate benefit to what you are 
doing.  In fact because of these changes we are diverging from BOTH kame 
and openbsd code bases.  I'm willing to do that but only after 
understanding the consequences.

	Sam