cvs commit: src/sys/geom/label g_label.c

Brian Fundakowski Feldman green at FreeBSD.org
Tue Aug 16 09:05:54 GMT 2005


On Tue, Aug 16, 2005 at 10:16:44AM +0200, Pawel Jakub Dawidek wrote:
> On Mon, Aug 15, 2005 at 08:58:14AM -0400, Brian Fundakowski Feldman wrote:
> +> > +> Why would we want to prevent the usage of a specific directory structure
> +> > +> to represent GEOM's namespace, if that's what the administrator wants?
> +> > 
> +> > If the label name is 'foo/bar' it doesn't seems right to create 'foo'
> +> > directory and provider 'bar' inside. The label could be also '../random'
> +> > or something like this and I want to save administrator/user nasty surprises
> +> > when he inserts some random CD.
> +> 
> +> I like the idea of rejecting the latter, but what is the harm of the first
> +> case?  If I call something "foo/bar", I'll be surprised to find out that
> +> it's located at /dev/foo_bar... my preference would be for the name to be
> +> rejected completely instead of remapped, if a '/' is to not be allowed,
> +> but that's my own.
> 
> 	# cd /dev/foo
> 	# rm/anything bar
> 
> There was no label 'bar', right. Anyway. Instead of rejecting labels with
> '/' I can print a warning on the console that a bit different label will be
> used. What do you say?

That seems much more conservative -- GEOM doing a uprintf() and printf()
to indicate that it's modified things.  Something a sysadmin would notice
at boot and a user at mount time of whatever.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\


More information about the cvs-all mailing list