cvs commit: src/sys/net if_var.h

Brooks Davis brooks at one-eyed-alien.net
Tue Aug 2 19:25:15 GMT 2005


On Tue, Aug 02, 2005 at 02:16:32PM -0400, John Baldwin wrote:
> On Tuesday 02 August 2005 01:43 pm, Robert Watson wrote:
> > rwatson     2005-08-02 17:43:35 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/net              if_var.h
> >   Log:
> >   Add if_addr_mtx to struct ifnet, a mutex to protect ifnet-related address
> >   lists.  Add accessor macros.
> >
> >   This changes the size of struct ifnet, but ideally, all ifnet consumers
> >   are now using if_alloc() to allocate these structures rather than
> >   embedding them into device driver softc's, so this won't modify the
> >   network device driver ABI.
> >
> >   MFC after:      1 week
> 
> It still modifies the ABI because of all the code that does 'ifp->if_foo' 
> unless you've added it to the end.

He did.  I should add some comments about this though.

FWIW, any consumers not using if_alloc() are jumping through some major
hoops to avoid a panic on if_attach() and asking for it.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20050802/a3851a33/attachment.bin


More information about the cvs-all mailing list