cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7

[Ruslan Ermilov]

On Sun, Jul 31, 2005 at 10:23:43AM +0200, Alexander Leidinger wrote:
> On Sun, 31 Jul 2005 09:31:59 +0200
> des at des.no (Dag-Erling Sm?rgrav) wrote:
> 
> > Alexander Leidinger <netchild at FreeBSD.org> writes:
> > > What's more preferred, the use of ".error", or the way you solved it?
> > 
> > depends on what you think should happen if a user tries
> > 
> > # make installworld delete-old
> 
> Ok, point taken.
> 
> > BTW, I don't really see why {check,delete}-old-* should be restricted
> > to native environments.  DESTDIR might point to e.g. an NFS-exported
> > filesystem from which thin clients of a different architecture boot.
> 
> Because of ObsoleteFiles.inc:
> ---snip---
> .if ${MACHINE_ARCH} != "alpha" && ${MACHINE_ARCH} != "sparc64"
> # 20040130: libkse renamed to libpthread
> OLD_FILES+=usr/lib/libkse.a
> OLD_FILES+=usr/lib/libkse.so
> .endif
> ---snip---
> 
> We could change this to TARGET_ARCH instead, but then the user has to
> set it, else he removes non-obsolete files. Even when we make it a
> documented requirement, I don't have a good feeling regarding this.
> There's too much foot-shooting potential if someone forgets to set it.
> I think it's more user friendly / ergonomic to keep the current
> restriction. With the restriction in place you need to have 2
> files (Makefile.inc1 and ObsoleteFiles.inc) or the NFS exported src
> directory on one client to remove the old files. This is a little bit
> more work, but forces the administrator to think a little bit about what
> he does. It's part of my "as failsafe as possible" design of this
> feature.
> 
> I don't object when someone wants to remove the restriction based upon
> a decission of a majority (committers, user complains, whatever).
> 
TARGET_ARCH is always set in Makefile.inc1.  It's set to MACHINE_ARCH
by default.  It should be safe to s/MACHINE_ARCH/TARGET_ARCH/ in
ObsoleteFiles.inc and remove the condition for nativeness.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20050802/8051923b/attachment.bin