cvs commit: src/sys/netinet ip_divert.c

Andre Oppermann andre at freebsd.org
Tue Oct 19 15:51:27 PDT 2004


Robert Watson wrote:
> 
> On Wed, 20 Oct 2004, Andre Oppermann wrote:
> 
> > Hmm... I'll take a look at those attempts and see what I can come up
> > with to get some general solution for the protocol cases.  The approach
> > of callout_drain() looks promising though.
> 
> BTW, it looks like the divert pcb zone uses UMA_ZONE_NOFREE so that the
> memory is type-stable (presumably in particular for the sysctl), so all
> memory allocated by the divert module for pcbs is likely leaked on unload.
> I'm beginning to think we should just block unload for divert and solve
> the unload problem another day for another protocol...

It is indeed an oversight by me not to uma_zdestroy() the zone on unload.
The sysctl handler uses normal malloc.

-- 
Andre


More information about the cvs-all mailing list