Unable to build apache2 with threads (Re: cvs commit: ports/Mk bsd.port.mk)

[Clement Laforet]

On Sun, 10 Oct 2004 10:34:33 +0800
Clive Lin <clive at tongi.org> wrote:

Hi Clive,

> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r1=1.498&r2=1.499
> 
> this seems to stop apache2 build with threads. (WITH_MPM=worker)

I know ;-)
Actually, this change make apache2 port "violate" PTHREAD_LIBS.
I'll try to find a nice fix.
 
>     dirty hack as below, although I dont think it is a correct fix...
Thanks. The patch below minimizes impacts (if there's any), IMHO.
portmgr is Cc'd for approval.

clem

--- Makefile.orig       Sun Oct 10 09:16:35 2004
+++ Makefile    Sun Oct 10 09:16:52 2004
@@ -138,7 +138,7 @@
 PLIST_SUB+=    PORTS_APR=""
 .endif
 
-WITH_PTHREAD_LIBS?=    ${PTHREAD_LIBS:S/-l//}
+WITH_PTHREAD_LIBS?=    ${PTHREAD_LIBS:S/-l//:S/-//}
 WITH_PTHREAD_CFLAGS?=  ${PTHREAD_CFLAGS}
 
 .include "${APACHEDIR}/Makefile.doc"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20041010/e79c4d6c/attachment.bin