cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h

[Moore, Robert]

I can add this next time I open up this interface.

I think there are a couple of other requests outstanding on
AcpiOsTableOverride(), perhaps in the SSDT area, I forget.


> -----Original Message-----
> From: Nate Lawson [mailto:nate at root.org]
> Sent: Tuesday, October 05, 2004 2:31 PM
> To: John Baldwin
> Cc: Takanori Watanabe; src-committers at FreeBSD.org;
cvs-src at FreeBSD.org;
> cvs-all at FreeBSD.org
> Subject: Re: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c
> acpidump.h
> 
> Nate Lawson wrote:
> > John Baldwin wrote:
> >> I agree.  It makes the user's lives a lot easier if they procedure
> >> remains:
> >>
> >> - acpidump > foo.asl
> >> - hack on foo.asl to fix it
> >> - compile foo.asl to foo.dsdt
> >> - load foo.dsdt in the loader
> >>
> >> and have it all just work.  Actually, you know, we could make this
> >> work on our own without requiring ACPI-CA to change.  You just need
to
> >> hack AcpiOsTableOverride() in OsdTable.c to return a pointer to an
> >> empty table for "SSDT" tables when the DSDT is overridden.  In
fact, I
> >> think that is probably where this behavior decision really belongs.
> >
> > Good idea, I'll look into this.  If feasible, I'll commit this and
> > revert the acpidump change.
> 
> Ok, I've committed a tested version with this approach.  The only
> annoying part is that setting NewTable to NULL means "don't override
> this one" so I had to supply an empty no-op table in place of the
SSDT.
>   I backed out the acpidump changes.  It would be better if ACPI-CA
had
> an option where returning AE_NO_TABLES or something would mean "ignore
> this table completely".  Right now, you can only override or leave the
> default table.
> 
> --
> Nate