cvs commit: ports/math/gnuplot Makefile

Oliver Eikemeier eikemeier at fillmore-labs.com
Sun Jun 27 17:21:49 PDT 2004


Pav Lucistnik wrote:

> In the unattended build, when no OPTIONS dialog is displayed, you don't
> have any WITH* and WITHOUT* variables set. Your port should behave as if
> default values were selected.
>
> OPTIONS=	OPTION "foo" on
>
> Default is to have OPTION on. When no WITH/WITHOUT* variables are
> generated, your test
>
> .if defined(WITH_OPTION)
>
> will fail. That's now the default you wanted. If you check instead
>
> .if !defined(WITHOUT_OPTION)
>
> it will work correctly in case OPTIONS were not processed. This nicely
> demonstrates in unattended build on packages on Bento, for example.

As a side note, generously changing WITH_* to WITHOUT_* breaks upgrading
for all people (like me) that use portupgrade to upgrade their ports.

Also, it might be intended to have a different set of options preselected
to choose from than those used for package building.

You should note changes like this at least in UPDATING.

-Oliver



More information about the cvs-all mailing list