cvs commit: src/sys/boot/i386/boot2 boot1.S

[Poul-Henning Kamp]

In message <20040602093149.D35427 at root.org>, Nate Lawson writes:

>By removing the callw/retw and moving the jmp to the end, A20 enable can't
>be called as a subroutine from elsewhere.  Will it be needed elsewhere?

Not that I could find.

>>  /*
>>   * Enable A20 so we can access memory above 1 meg.
>> + * Use the zero-valued %cx as a timeout for embedded hardware which do not
>> + * have a keyboard controller.
>>   */
>>  seta20: 	cli				# Disable interrupts
>> -seta20.1:	inb $0x64,%al			# Get status
>
>Should be a "movw TIMEOUT, %cx" here.  (Or whatever the timeout constant
>is.)

Uhm, you are aware that space is very limited, right ?  Please see
the constant above for how we get the TIMEOUT value.


-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.