[src] cvs commit: src/sys/dev/fdc fdc.c fdc_isa.c fdc_pccard.c fdcvar.h src/sys/modules/fdc Makefile

[Nate Lawson]

Warner Losh wrote:
> imp         2004-07-07 22:35:27 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/fdc          fdc.c 
>     sys/modules/fdc      Makefile 
>   Added files:
>     sys/dev/fdc          fdc_isa.c fdc_pccard.c fdcvar.h 
>   Log:
>   Break out the isa and pccard front ends from fdc.  This is the first
>   step in making this driver more attachment neutral.  Others plan on
>   adding acpi front ends.
>   
>   Still need to cleanup the MI part of the driver because it isn't as
>   bus independent as it could be.
>   
>   Revision  Changes    Path
>   1.276     +12 -304   src/sys/dev/fdc/fdc.c
>   1.1       +145 -0    src/sys/dev/fdc/fdc_isa.c (new)
>   1.1       +114 -0    src/sys/dev/fdc/fdc_pccard.c (new)
>   1.1       +134 -0    src/sys/dev/fdc/fdcvar.h (new)
>   1.9       +2 -14     src/sys/modules/fdc/Makefile

I don't think you should put your copyright on code that is 100% from 
fdc.c.  Bruce complained about this for my version of fdcvar.h.

Also, you went the path of completely exposing the softc (and the 
requisite enum fields).  In response to Bruce's comments, I had made 
major efforts to hide it and have accessor functions for the probe 
routines.  This is why I didn't commit the acpi attachment a month ago 
(and still haven't committed it).  I'm a little frustrated that it 
appears I could have gone with the exposed softc approach and saved 
quite a few hours of work.

-Nate