green 2004/04/14 07:57:50 PDT
FreeBSD src repository
Modified files:
sys/dev/sound/isa ad1816.c ess.c mss.c sb16.c sb8.c sbc.c
sys/dev/sound/pci cmi.c csa.c csapcm.c ds1.c emu10k1.c
ich.c t4dwave.c
sys/dev/sound/pcm sound.h
Log:
The newpcm headers currently #define away INTR_MPSAFE and INTR_TYPE_AV
because they bogusly check for defined(INTR_MPSAFE) -- something which
never was a #define. Correct the definitions.
This make INTR_TYPE_AV finally get used instead of the lower-priority
INTR_TYPE_TTY, so it's quite possible some improvement will be had
on sound driver performance. It would also make all the drivers
marked INTR_MPSAFE actually run without Giant (which does seem to
work for me), but:
INTR_MPSAFE HAS BEEN REMOVED FROM EVERY SOUND DRIVER!
It needs to be re-added on a case-by-case basis since there is no one
who will vouch for which sound drivers, if any, willy actually operate
correctly without Giant, since there hasn't been testing because of
this bug disabling INTR_MPSAFE.
Found by: "Yuriy Tsibizov" <Yuriy.Tsibizov at gfk.ru>
Revision Changes Path
1.32 +1 -1 src/sys/dev/sound/isa/ad1816.c
1.30 +1 -1 src/sys/dev/sound/isa/ess.c
1.88 +2 -2 src/sys/dev/sound/isa/mss.c
1.83 +1 -1 src/sys/dev/sound/isa/sb16.c
1.76 +1 -1 src/sys/dev/sound/isa/sb8.c
1.40 +1 -1 src/sys/dev/sound/isa/sbc.c
1.27 +1 -1 src/sys/dev/sound/pci/cmi.c
1.29 +1 -1 src/sys/dev/sound/pci/csa.c
1.30 +1 -1 src/sys/dev/sound/pci/csapcm.c
1.39 +1 -1 src/sys/dev/sound/pci/ds1.c
1.48 +1 -1 src/sys/dev/sound/pci/emu10k1.c
1.41 +1 -1 src/sys/dev/sound/pci/ich.c
1.43 +1 -1 src/sys/dev/sound/pci/t4dwave.c
1.58 +3 -8 src/sys/dev/sound/pcm/sound.h