cvs commit: src/sys/dev/usb ubsa.c

Takanori Watanabe takawata at axe-inc.co.jp
Sun Nov 30 21:41:47 PST 2003


In message <20031130201755.K11560 at root.org>, Nate Lawson wrote:
>On Sun, 30 Nov 2003, Shunsuke Akiyama wrote:
>>   Modified files:        (Branch: RELENG_4)
>>     sys/dev/usb          ubsa.c
>>   Log:
>>   MFC: revision 1.11
>>
>>   Apply some fixups in the driver_t's.
>>
>>   Revision  Changes    Path
>>   1.2.2.2   +1 -1      src/sys/dev/usb/ubsa.c
>>
>> --- src/sys/dev/usb/ubsa.c:1.2.2.1	Wed Dec 11 12:54:47 2002
>> +++ src/sys/dev/usb/ubsa.c	Sun Nov 30 04:53:40 2003
>> @@ -237,7 +237,7 @@
>>  };
>>
>>  Static driver_t ubsa_driver = {
>> -	"ubsa",
>> +	"ucom",
>>  	ubsa_methods,
>>  	sizeof (struct ubsa_softc)
>>  };
>>
>
>Are you sure this is the direction you want to go?  The driver is called
>ubsa and has a man page called ubsa.4.  Why make it inaccurate?

This is correct. Module name itself is ubsa, but this imprements
a kind of "ucom" interface and it shares ucom_devclass with other
ucom drivers. Driver name should be same in all devclass, or the unit number 
management will got wrong.
Just like both host-pci bus bridge and pci-pci bus bridge has
same name "pcib".




More information about the cvs-all mailing list