cvs commit: ports/java/jdk13/files patch-iomgr.c

Mario Sergio Fujikawa Ferreira lioux at FreeBSD.org
Tue May 6 06:48:19 PDT 2003


On Mon, May 05, 2003 at 11:10:40PM -0700, Greg Lewis wrote:
> glewis      2003/05/05 23:11:02 PDT
> 
>   FreeBSD ports repository
> 
>   Added files:
>     java/jdk13/files     patch-iomgr.c 
>   Log:
>   . Remove an assert() which asserts that if isatty() is true then
>     ttyname() must not return NULL.  This isn't entirely true according
>     to the manual page (the device must be able to be found as well) and
>     certainly appears to not necessarily be true in the package building
>     environment on bento (plus at least the PR submitter's environment).
>   
>     Note that this assert() was, of course, only ever triggered when
>     running in debug mode (which most people don't, but does happen
>     during the build in some parts).  Also note that there is a check
>     for isatty() preceding the call for ttyname() and a NULL return
>     from ttyname() is handled, so removing this assert should not
>     create any problems.

	Shouldn't we bump PORTREVISION?

-- 
Mario S F Ferreira - DF - Brazil - "I guess this is a signature."
FreeBSD Committer | CS Developer
flames to beloved devnull at someotherworldbeloworabove.org
feature, n: a documented bug | bug, n: an undocumented feature


More information about the cvs-all mailing list