cvs commit: src/sys/conf options src/sys/netinet ip_output.c

Bosko Milekic bmilekic at unixdaemons.com
Thu Mar 27 14:43:59 PST 2003


On Thu, Mar 27, 2003 at 04:31:02PM -0600, Mike Silbersack wrote:
> 
> I'll give this a shot when I get time to work on the patch next.  If a
> similar change to m_dup_pkthdr works fine, do you want me to go ahead and
> commit it?

  Yes.  Just make sure to test and let me know if/when you do, because I
  have some other improvements which rely on this change in my tree.

> Thanks,
> 
> Mike "Silby" Silbersack
> 
> On Thu, 27 Mar 2003, Bosko Milekic wrote:
> 
> >
> > See attached.  Similar logic may be applied to m_dup_pkthdr().
> >
> > On Thu, Mar 27, 2003 at 05:58:00PM +0100, Maxime Henrion wrote:
> > > Bosko Milekic wrote:
> > > >
> > > > Can you please still use m_gethdr() or m_getcl() to do the allocations
> > > > in the defragment function?  Similarly, for > MCLBYTES, use m_getm().
> > > > Don't roll your own.
> > >
> > > Please see my reply to Mike for the first version of his patch.  He
> > > couldn't do this because m_dup_pkthdr() has a KASSERT() that makes it
> > > panic if we have a cluster attached to the mbuf.
> > >
> > > Cheers,
> > > Maxime
> > >
> >
> > --
> > Bosko Milekic
> > bmilekic at unixdaemons.com
> > bmilekic at FreeBSD.org
> >
> >
> 

-- 
Bosko Milekic
bmilekic at unixdaemons.com
bmilekic at FreeBSD.org



More information about the cvs-all mailing list