cvs commit: src/sys/coda coda_fbsd.c coda_vnops.c src/sys/compat/linux linux_misc.c src/sys/dev/raidframe rf_freebsdkintf.c src/sys/fs/hpfs hpfs_vfsops.c src/sys/fs/msdosfs msdosfs_vfsops.c src/sys/fs/ntfs ntfs_vfsops.c src/sys/fs/nwfs ...

[Poul-Henning Kamp]

In message <20030726091651.GB42924 at elvis.mu.org>, Alfred Perlstein writes:
>* Poul-Henning Kamp <phk at FreeBSD.org> [030726 00:32] wrote:
>> phk         2003/07/26 00:32:23 PDT
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/coda             coda_fbsd.c coda_vnops.c 
>>     sys/compat/linux     linux_misc.c 
>>     sys/dev/raidframe    rf_freebsdkintf.c 
>>   Log:
>>   Add a "int fd" argument to VOP_OPEN() which in the future will
>>   contain the filedescriptor number on opens from userland.
>>   
>>   The index is used rather than a "struct file *" since it conveys a bit
>>   more information, which may be useful to in particular fdescfs and /dev/fd/*
>>   
>>   For now pass -1 all over the place.
>
>This seems like a mistake, it forces one to have a struct filedesc instead
>of merely faking up a struct file.
>
>What if one wants to have a cookie without a filedesc?
>
>Am I mistaken?

I'm afraid that I totally fail to even understand your question...

The objective here is to improve the situation where a vnode open
results in a non-vnode method vector on the file, /dev/fd[0-2],
/dev/stream etc.  The index can be used with the (already) passed
thread pointer to access the relevant file entry.

BTW: I am not done with this change, the next commit adds the
identical argument to vn_open().

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.