cvs commit: src/sys/dev/fxp if_fxp.c

M. Warner Losh imp at bsdimp.com
Mon Apr 14 12:04:24 PDT 2003


In message: <20030414124016.O39446 at sasami.jurai.net>
            "Matthew N. Dodd" <mdodd at FreeBSD.ORG> writes:
: On Mon, 14 Apr 2003, M. Warner Losh wrote:
: > In message: <200304140945.h3E9jPCe005099 at repoman.freebsd.org>
: >             Maxim Sobolev <sobomax at FreeBSD.org> writes:
: > :   Before attaching device set PCIM_CMD_PORTEN in addition to
: > :   PCIM_CMD_MEMEN and PCIM_CMD_BUSMASTEREN, becaise some braindead
: > :   BIOSes (such as one found in my vprmatrix notebook) forget
: > :   to initialize it properly resulting in attachment failure.
: >
: > Actually, code like this should be the pci bus, since all driver have
: > this issue...
: 
: Likely this could be added to the bus_alloc_resource() path...  Doing a
: sanity check on requests and then enabling the resource seems like the
: correct solution.

Yes.  That's what I had in mind.  However, the bus master stuff still
may need to be done in the drivers since I don't think that the
bus_space_dma routines go through newbus at all...

Warner


More information about the cvs-all mailing list