Redundant code in aic7xxx_proc.c?

Mads Bondo Dydensborg madsdyd at challenge.dk
Fri Jul 21 03:35:54 PDT 2000


Hello.

I have been confused by these lines in the function aic7xxx_proc_info in 
aic7xxx_proc.c:

---------------
  HBAptr = p->host;

  if (inout == TRUE) /* Has data been written to the file? */ 
  {
    return (aic7871_set_info(buffer, length, HBAptr));
  }

  p = (struct aic7871_host *) HBAptr->hostdata;
---------------

Isn't the last line redundant? I mean, if p should change its value based
on that assignment, wouldn't something be really wrong/weird?

BTW: this is the file as distributed in kernel 2.2.13.

Mads

-- 
Mads Bondo Dydensborg.                               madsdyd at challenge.dk
Pretty cool, the kind of power information technology puts in our hands
these days. 
    - Securityfocus on probing 36000000 hosts for known problems in 3 weeks



To Unsubscribe: send mail to majordomo at FreeBSD.org
with "unsubscribe aic7xxx" in the body of the message




More information about the aic7xxx mailing list