[Bug 273697] deskutils/xfce4-tumbler: add dependency on graphics/libheif

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 10 Sep 2023 13:37:46 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273697

Guido Falsi <madpilot@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |madpilot@FreeBSD.org
             Status|New                         |Open

--- Comment #2 from Guido Falsi <madpilot@FreeBSD.org> ---
Hi,

Thanks for pointing this out. I did not notice this was something supported.

Although I have a problem adding this as an option, since there is no actual
knob to enable/disable it in the port. The knob would simply add a dependency,
changing nothing in the build. This is not the real idea behind dependencies
and options.

Also I see no reference to this library in xfce4-thumbnailer. Are we sure this
dependency would not belong to some other part that tumbler depends on?

On the other hand if this is something that tumbler loads at runtime of
available, I'm not sure adding a dependency and an option is the correct
solution in this case. Maybe adding a note in the pkg-message?

The fast it is an option does not fix excess dependency, it would not help
binary packages users.

I'm looking into this, but adding an optional dependency for something detected
at runtime does not look correct, user can simply be directed to pkg install
the required part if interested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.