Re: [package - main-amd64-default][www/midori] Failed for midori-9.0_7 in build

From: Guido Falsi <mad_at_madpilot.net>
Date: Sat, 11 Feb 2023 09:41:56 UTC
On 11/02/23 07:41, pkg-fallout@FreeBSD.org wrote:
> You are receiving this mail as a port that you maintain
> is failing to build on the FreeBSD package build server.
> Please investigate the failure and submit a PR to fix
> build.
> 
> Maintainer:     xfce@FreeBSD.org
> Log URL:        https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p58633340e9ed_s5636590214/logs/midori-9.0_7.log
> Build URL:      https://pkg-status.freebsd.org/beefy18/build.html?mastername=main-amd64-default&build=p58633340e9ed_s5636590214
> Log:
> 
> =>> Building www/midori
> build started at Sat Feb 11 06:40:48 UTC 2023
> port directory: /usr/ports/www/midori
> package name: midori-9.0_7
> building for: FreeBSD main-amd64-default-job-12 14.0-CURRENT FreeBSD 14.0-CURRENT 1400079 amd64
> maintained by: xfce@FreeBSD.org
> Makefile ident:
> Poudriere version: 3.2.8-23-ga7f8d188
> Host OSVERSION: 1400073
> Jail OSVERSION: 1400079
> Job Id: 12
> 
[...]
>   ude/gobject-introspection-1.0 -I/usr/local/include/json-glib-1.0 -I/wrkdirs/usr/ports/www/midori/work/.build -I/wrkdirs/usr/ports/www/midori/work/.build/core -I/wrkdirs/usr/ports/www/midori/work/.build/extensions -O2 -pipe  -Wno-return-type -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -O2 -pipe  -Wno-return-type -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -DNDEBUG -fPIC -g -fPIC -w -Werror -MD -MT extensions/CMakeFiles/session.dir/session.c.o -MF extensions/CMakeFiles/session.dir/session.c.o.d -o extensions/CMakeFiles/session.dir/session.c.o -c /wrkdirs/usr/ports/www/midori/work/.build/extensions/session.c
> FAILED: extensions/CMakeFiles/session.dir/session.c.o
> /usr/bin/cc -DGCR_API_SUBJECT_TO_CHANGE -DGETTEXT_PACKAGE=\"midori\" -Dsession_EXPORTS -I/wrkdirs/usr/ports/www/midori/work/core-9.0 -I/wrkdirs/usr/ports/www/midori/work/core-9.0/core -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/libsoup-2.4 -I/usr/local/include/libxml2 -I/usr/local/include/gtk-3.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/harfbuzz -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -I/usr/local/include/fribidi -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/gio-unix-2.0 -I/usr/local/include/libepoll-shim -I/usr/local/include/atk-1.0 -I/usr/local/include/at-spi2-atk/2.0 -I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include -I/usr/local/include/at-spi-2.0 -I/usr/local/include/webkitgtk-4.0 -I/usr/local/include/gcr-3 -I/usr/local/include/gck-1 -I/usr/local/include/p11-kit-1 -I/usr/local/include/libpeas-1.0 -I/usr/local/include/gobject-in
>   trospection-1.0 -I/usr/local/include/json-glib-1.0 -I/wrkdirs/usr/ports/www/midori/work/.build -I/wrkdirs/usr/ports/www/midori/work/.build/core -I/wrkdirs/usr/ports/www/midori/work/.build/extensions -O2 -pipe  -Wno-return-type -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -O2 -pipe  -Wno-return-type -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -DNDEBUG -fPIC -g -fPIC -w -Werror -MD -MT extensions/CMakeFiles/session.dir/session.c.o -MF extensions/CMakeFiles/session.dir/session.c.o.d -o extensions/CMakeFiles/session.dir/session.c.o -c /wrkdirs/usr/ports/www/midori/work/.build/extensions/session.c
> /wrkdirs/usr/ports/www/midori/work/core-9.0/extensions/session.vala:73:69: error: incompatible integer to pointer conversion passing 'gint64' (aka 'long') to parameter of type 'gpointer' (aka 'void *') [-Wint-conversion]
>                  g_object_set_data_full ((GObject*) _data_->_tmp30_, "session_id", _data_->session_id, NULL);
>                                                                                    ^~~~~~~~~~~~~~~~~~
> /usr/local/include/glib-2.0/gobject/gobject.h:618:29: note: passing argument to parameter 'data' here
>                                                 gpointer        data,
>                                                                 ^
> /wrkdirs/usr/ports/www/midori/work/core-9.0/extensions/session.vala:74:65: error: incompatible integer to pointer conversion passing 'gint64' (aka 'long') to parameter of type 'gpointer' (aka 'void *') [-Wint-conversion]
>                  g_object_set_data_full ((GObject*) _data_->_tmp33_, "pinned", _data_->_tmp31_, NULL);
>                                                                                ^~~~~~~~~~~~~~~
> /usr/local/include/glib-2.0/gobject/gobject.h:618:29: note: passing argument to parameter 'data' here
>                                                 gpointer        data,
>                                                                 ^
> /wrkdirs/usr/ports/www/midori/work/core-9.0/extensions/session.vala:214:16: error: incompatible pointer to integer conversion assigning to 'gint64' (aka 'long') from 'gconstpointer' (aka 'const void *') [-Wint-conversion]
>                                  _data_->id = _data_->_tmp4_;
>                                             ^ ~~~~~~~~~~~~~~
> /wrkdirs/usr/ports/www/midori/work/core-9.0/extensions/session.vala:285:67: error: incompatible integer to pointer conversion passing 'gint64' (aka 'long') to parameter of type 'gpointer' (aka 'void *') [-Wint-conversion]
>          g_object_set_data_full ((GObject*) _data_->_tmp8_, "session_id", _data_->id, NULL);
>                                                                           ^~~~~~~~~~
> /usr/local/include/glib-2.0/gobject/gobject.h:618:29: note: passing argument to parameter 'data' here
>                                                 gpointer        data,
>                                                                 ^
> 4 errors generated.
> [ 38% 60/156] cd /wrkdirs/usr/ports/www/midori/work/.build/extensions && /usr/local/bin/intltool-merge --desktop-style /wrkdirs/usr/ports/www/midori/work/core-9.0/po /wrkdirs/usr/ports/www/midori/work/core-9.0/extensions/session.plugin.in session.plugin
> Merging translations into session.plugin.
> ninja: build stopped: subcommand failed.
> ===> Compilation failed unexpectedly.
> Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
> the maintainer.
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/ports/www/midori
> 

Unluckily the issue is in a "vala" source file, and I'm unable to find a 
fix, not knowing the language details. I guess it is relatively easy for 
people fluent in vala.

I'm going to mark the port as BROKEN with clang 15 (OSVERSION >= 
1400079) at present. If anyone finds a fix please file a PR on bugzilla.

-- 
Guido Falsi <mad@madpilot.net>