From nobody Sat Dec 02 19:48:27 2023 X-Original-To: xfce@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SjL8C6dKTz53YLM for ; Sat, 2 Dec 2023 19:48:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SjL8C3NFQz4Wp4 for ; Sat, 2 Dec 2023 19:48:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701546507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h3UinhY3SGnJrntSk7V8kI8PuVha400tgP36AaochvY=; b=Ab3GsWRR6IzoHBOHno+csH2vet/O5iFn3jp/K6RnzAtmEkjqCC9iVxlfWiaocgtLRgrTtO zyl7GYEdQzUfrkgMJF3Dgltig0q42m0wX3ujukop8kftdwfeOM8YJANkORbJLeb5GV2SMg TKLCvdR3MHAHqhB51XWOANbjgrmU22qzHkpdC6K6aDbbQ2h4WbynVO3bFCiYz5cQIxRJje lojF3b/RgiTEpDunFH/ZgDhXdeBGY8SgenBTmfeQTcHxCXDYKT2IAKCf9BJXe/w1T0Im2k e75tmxLpg77jHHTNpHgpxljPZaa+a/AzBEqzmjxONfLvcvH0CSyLJ60eAJbBMQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701546507; a=rsa-sha256; cv=none; b=xERH7Kf1QyqBeyZL17o2igQu5PrmZsvCuOQv1RkoildzSjfbmylA3h2EuUts3T1ggvr76j +rznshTES5CqNO7iVrMlY4GLHf3A8Pmh+fPX5GhM8wuyEvjd76F/O+AU7gt3jTJ+Pjdvs/ 5kmw5lec2DBnmYyZswyqoO83RIhgM0cSHWqNb4DDj5EeGRuBJH9TgAMjLnJ4oX4KYKLZiP Ib1xeRIo4C1SxD9HMu8ywuJIIUgaR55a2qSbYK+Pq+lgXUUpllUf7Ii1roMpJN4ggaVScB 91VShScVToachnf3bi70VULjYI9tMGh5+jq64eawRj4T8gaMMWb3iArqWU6e9Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SjL8C2LY8zVc0 for ; Sat, 2 Dec 2023 19:48:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3B2JmRVR081140 for ; Sat, 2 Dec 2023 19:48:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3B2JmRGh081139 for xfce@FreeBSD.org; Sat, 2 Dec 2023 19:48:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 275487] x11-themes/xfce-icons-elementary (still) not prefix-safe Date: Sat, 02 Dec 2023 19:48:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: flagtypes.name cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: XFCE List-Archive: https://lists.freebsd.org/archives/freebsd-xfce List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-xfce@freebsd.org X-BeenThere: freebsd-xfce@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275487 Guido Falsi changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|maintainer-feedback?(xfce@F |maintainer-feedback+ |reeBSD.org) | CC| |madpilot@FreeBSD.org Status|New |In Progress --- Comment #1 from Guido Falsi --- Hi, Thanks for the patch! You make good points, Just to be pedantic I'll elabor= ate a little: I suspect the improper management of prefix could be a vestige of the past = when (I have not checked it is a mere hypothesis) elementary theme build system = did not allow it as an argument. Also while I agree that it is anyway better to respect CFLAGS, there is not strict rule on that about programs that are not actually installed on the system. Upstream could in fact have special needs for cflags of internal to= ols that could conflict with ports system CFLAGS. This is not the case though, = so your patch looks fine in this respect too. BTW the +=3D is not needed at that point of the Makefile, we have still to include any other makefile, so there is no existing MAKE_ARGS variable to append to. I'm going to test this patch and commit it soon. --=20 You are receiving this mail because: You are the assignee for the bug.=