[Bug 257692] [NEW PORT] x11/xfce4-docklike-plugin A modern, minimalist taskbar for Xfce
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 14 Aug 2021 19:41:24 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692
Guido Falsi <madpilot@FreeBSD.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #227094|0 |1
is obsolete| |
--- Comment #12 from Guido Falsi <madpilot@FreeBSD.org> ---
Created attachment 227193
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=227193&action=edit
Updated patch
Hi,
I have tested the port in poudriere and ran it.
I did make a few adjustments:
- Converted it to USE_GITLAB, the changes should be straightforward.
- The port was missing some build time dependencies:
USES=pkgconfig
USE_GNOME=intlrtool
Most probably you did not spot them because the usually happen to be already
present on a live system. This kind of thing is why testing ports in poudriere
is highly recommended.
Also, the pkg-descr file had a long text all in one line. The rules mandate for
wrapping at 80 char length.
Apart from these things it looks fine.
I'd rather have you acknowledge my changes before committing it.
Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.