[Bug 257692] [NEW PORT] x11/xfce4-docklike-plugin A modern, minimalist taskbar for Xfce

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 10 Aug 2021 09:44:10 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692

--- Comment #8 from Guido Falsi <madpilot_at_FreeBSD.org> ---
(In reply to Quentin Baker from comment #7)

In the while I noticed some issues by skimming you submission patch:

instead of doing:

DISTVERSION=    v0.3.0

you should use:

PORTVERSION=    0.3.0
DISTVERSIONPREFIX=      v

This could also help with gitlab.


Another issue, usually lib depends are distributed one per line like this:

LIB_DEPENDS=    libinotify.so:devel/libinotify \
                libharfbuzz.so:print/harfbuzz

USES and _USE lines content should be sorted

The pkg-descr should be expanded. It makes little sense to have the same text
in the port COMMENT (which requires a very succinct description) and the
pkg-descr which should expand on what the software actually does. Could you
rewrite the pkg-descr with a more thorough description? You can also copy it
from upstream, but it has to be something more than the COMMENT content.

Also I have some perplexity about the LDFLAGS you added, maybe a patch to the
Makefile or configure script would be better, but for this last one testing is
needed to decide the best solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
Received on Tue Aug 10 2021 - 09:44:10 UTC

Original text of this message