From nobody Wed Mar 27 16:09:27 2024 X-Original-To: x11@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V4Wp02G9vz5Fl2V for ; Wed, 27 Mar 2024 16:09:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V4Wnz6XGVz4H57 for ; Wed, 27 Mar 2024 16:09:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711555767; a=rsa-sha256; cv=none; b=G6q5n76HqeQQKYdr0hUTUMurLAWhRbKeYxrbwexzhS4c4dVgmGpO10J/3Jimtb4Egxu1rj LyTh2pmbXICM6er0iwtV+Z5/HUcfgAbuvq982uZZk7x+7YEufQ5lK/2OEHzmTs7SMr9V4j 308Cgg8RM5fqRw04F10TtJjycFXgjKyG1qF9FwnFt8FDVrqnH649wYQxCc4NvbwGewwtxK Sn/ahol4ZLQ8y7bw0AG5yNO1ia845Y/svQ1Z5/7LyOlTqcdK2ZYPBx27UsPqIHF2PzME4C hOfwthhaAUSkFnGXq6LLj7I3u0DyHr2cG7Q4Wv7B4G29MAGUWridjPJGquAYPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711555767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7To2xiqEQSqanHk6hKc3uib1kZhqnxsCvgscodms6Q=; b=a+2qj4xdTqWOKzPxx91Z81Z+LArXTOQLRqLm+4U1kxchchWa2ST63T3fgqQdoRJ7RFuxCn RbMttwuRb6uct3QtEJ9Rgeyq9CQHgS9VZgeIP60a8LjH73YX6d7Wx929PT6XZaRMaGgOsF lTaJ4FMgRPfCDwSxWs6uTO02kNFyfPRyWjjg+wwnEI15i7FwK0R33pzqF3rfV/HZaX/uEV jNuDCBEB2dJJzQOFpw1gPotWwCVIQfxtZS8NFFlwDAQfOd6U0IAP3ET/adGDNn0Hneh68O ON259nU9/biiXeu+0DYEy0d6hoEPA9n7jfQyvmIuJS4lPBDrKztCCsujTNS1Zw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4V4Wnz5MwvzqKs for ; Wed, 27 Mar 2024 16:09:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 42RG9Rad018950 for ; Wed, 27 Mar 2024 16:09:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 42RG9RLl018943 for x11@FreeBSD.org; Wed, 27 Mar 2024 16:09:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: [Bug 276614] graphics/mesa-dri:fix os_same_file_description warning Date: Wed, 27 Mar 2024 16:09:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback- X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: X11 List-Archive: https://lists.freebsd.org/archives/freebsd-x11 List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276614 Jan Beich changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jbeich@FreeBSD.org | --- Comment #44 from Jan Beich --- (In reply to Yusuf Khan from comment #42) > although if the memory leak is as severe as you say on certain applicatio= ns I've challenged your severity claim but didn't state my own, only pointed at related upstream findings. The warning disappeared from my dogfood plate 3 years ago in ports c14ad44ccafc, so I didn't have time to gather much data.= The ongoing cost of uncertainty in my own QA and when reporting various bugs upstream was too much to not just fix it. (In reply to Ivan Rozhuk from comment #43) > 1. How you has detect mem leak? Indirectly by logging every (not just the first) failed os_same_file_description() call (with PID and errno) into /var/log/messages. This doesn't track the leaked memory size. > 2. How it is possible to leak in syslog()? Look inside the patch. It merely hooks ad hoc warnings into MESA_LOG facili= ty and changes MESA_LOG from "file" to "syslog" by default. Logging into to st= derr isn't reliable if Xorg is started by a greeter (graphical login manager aka display manager) and changing MESA_LOG_FILE isn't reliable with setuid applications such as Xorg (until bug 273161). Besides, Mesa warnings are ki= nda serious unlike the rest of stderr output after startx, which often includes regular and noisy applications. --=20 You are receiving this mail because: You are the assignee for the bug.=