From nobody Thu Sep 14 22:42:15 2023 X-Original-To: x11@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RmslD25KFz4snR7 for ; Thu, 14 Sep 2023 22:42:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RmslC67g3z3QCY for ; Thu, 14 Sep 2023 22:42:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694731335; a=rsa-sha256; cv=none; b=ORPMp7NUEKFTMKQJE91Sd54QX/YwvthymSvOxi9lbETSE89v/N5wC+q3NDUuU7yZ1+cGxW txAtzi0sENlT3CaRG7tYGpkG/TfHhCnfZwuuzvoYFaECszrrcxutcZJZegoYhTbFwjiSgJ IgT/h4GqsiyjejQwxeBnrMO0THgw5vwAvpYOPlzkwVjcoDNTTrIICB3X7HFXHX4HIDt4t2 UkmDhP6D6/qIbeZGLAKj45GcI8SFEEzTC8p4ucqDP78pkhFYMipI68yndZdoe4E2IyOZV/ yJmCVtTC07eV4zzgheDWsSQ7o0XNg0ywn9W7+sQgSnUDZQslkbpIzF+6PiIUsw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694731335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aZOct2OH/t05Z3oot5W8gz5fXLGlz3iB0sJZ7hCCgbI=; b=Hpof2MXPm2sFH36L3wGlnrqQkIXYRQ2639uN7+0rGdP4/59tmeQoO4kCpVaUpmHM59VJ2t je28/2Yo+H0tAYO07VGRvS0OVEmJul3Ppf775oRuObjjgHt1u/+DnE00KBeMZfpUZTQ12s CrHFQGAE548LCj2qzOCFjYMnrPVKuMxJJm+D8achhaf9709MEOQtk7q0JNsjcgjrKwinve yIF/w+eeeR9owRlm6L2tX/l7bEAxt480JDkEbTyqp/6+XGLSAkCifPqpEZKls1IYMlVUxC B/lG7LKK5/tVRvV77Vo9Jb5NcbGwaPGqhlnDCUKVC8MUT/ns9Rh9zIjIt0fAYw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RmslC57ZVz1F7V for ; Thu, 14 Sep 2023 22:42:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38EMgFQS021505 for ; Thu, 14 Sep 2023 22:42:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38EMgFU9021504 for x11@FreeBSD.org; Thu, 14 Sep 2023 22:42:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: maintainer-approval requested: [Bug 273806] x11/libXcursor: Avoid duplicated path in XCURSORPATH : [Attachment 244858] patch v1 Date: Thu, 14 Sep 2023 22:42:15 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: X11 List-Archive: https://lists.freebsd.org/archives/freebsd-x11 List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-x11@freebsd.org X-BeenThere: freebsd-x11@freebsd.org MIME-Version: 1.0 Guido Falsi has asked freebsd-x11 (Nobody) for maintainer-approval: Bug 273806: x11/libXcursor: Avoid duplicated path in XCURSORPATH https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273806 Attachment 244858: patch v1 https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D244858&action=3Dedit --- Description --- by default libXcursor is being build passing to it an ICONDIR that causes t= he configure script to define an XCURSORPATH with that value duplicated. This = can be seen in any build log, the cc commands get this argument: -DXCURSORPATH=3D\"~/.local/share/icons:~/.icons:/usr/local/share/icons:/usr= /local /share/pixmaps:/usr/local/share/icons\" This is causing issues with xfce4-mouse-settings from xfce4-settings port, which scans this path for cursor themes. This software performs no checks f= or duplicates, so cursor themes are duplicated in the UI. The details of this are in bug #273744 I have checked the configure script, which has some simple check to try to = avid such duplicates, but actually fails due to variable substitutions being performed in multiple steps and the check for equal variables fails to catch our path. So, to avoid this, I thought we could directly pass the full xcursor search path with the configure --with-cursorpath variable, so we have full control over it. Testing in poudriere shows it does what it is expected, I'm going to run te= st it on my machines as soon the build run ends. Can this be approved? Thanks in advance.