[Bug 270485] x11/libXpm: update to 3.5.15

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270485

Jan Beich <jbeich@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://lists.x.org/archive
                   |                            |s/xorg-announce/2023-Januar
                   |                            |y/003313.html

--- Comment #2 from Jan Beich <jbeich@FreeBSD.org> ---
Disclaimer: I'm not part of x11@, don't use libXpm and don't maintain any port
that depends on libXpm. Feel free to ignore my review.

pkg-plist changes are missing:

$ poudriere testport -j 131amd64 x11/libXpm
[...]
===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: man/man3/XpmAttributesSize.3.gz
Error: Orphaned: man/man3/XpmCreateBuffer.3.gz
Error: Orphaned: man/man3/XpmCreateBufferFromImage.3.gz
Error: Orphaned: man/man3/XpmCreateBufferFromPixmap.3.gz
Error: Orphaned: man/man3/XpmCreateBufferFromXpmImage.3.gz
Error: Orphaned: man/man3/XpmCreateData.3.gz
Error: Orphaned: man/man3/XpmCreateDataFromImage.3.gz
Error: Orphaned: man/man3/XpmCreateDataFromPixmap.3.gz
Error: Orphaned: man/man3/XpmCreateDataFromXpmImage.3.gz
Error: Orphaned: man/man3/XpmCreateImage.3.gz
Error: Orphaned: man/man3/XpmCreateImageFromBuffer.3.gz
Error: Orphaned: man/man3/XpmCreateImageFromData.3.gz
Error: Orphaned: man/man3/XpmCreateImageFromXpmImage.3.gz
Error: Orphaned: man/man3/XpmCreatePixmap.3.gz
Error: Orphaned: man/man3/XpmCreatePixmapFromBuffer.3.gz
Error: Orphaned: man/man3/XpmCreatePixmapFromData.3.gz
Error: Orphaned: man/man3/XpmCreatePixmapFromXpmImage.3.gz
Error: Orphaned: man/man3/XpmCreateXpmImage.3.gz
Error: Orphaned: man/man3/XpmCreateXpmImageFromBuffer.3.gz
Error: Orphaned: man/man3/XpmCreateXpmImageFromData.3.gz
Error: Orphaned: man/man3/XpmCreateXpmImageFromImage.3.gz
Error: Orphaned: man/man3/XpmCreateXpmImageFromPixmap.3.gz
Error: Orphaned: man/man3/XpmFree.3.gz
Error: Orphaned: man/man3/XpmFreeAttributes.3.gz
Error: Orphaned: man/man3/XpmFreeExtensions.3.gz
Error: Orphaned: man/man3/XpmFreeXpmImage.3.gz
Error: Orphaned: man/man3/XpmFreeXpmInfo.3.gz
Error: Orphaned: man/man3/XpmGetErrorString.3.gz
Error: Orphaned: man/man3/XpmLibraryVersion.3.gz
Error: Orphaned: man/man3/XpmMisc.3.gz
Error: Orphaned: man/man3/XpmRead.3.gz
Error: Orphaned: man/man3/XpmReadFileToBuffer.3.gz
Error: Orphaned: man/man3/XpmReadFileToData.3.gz
Error: Orphaned: man/man3/XpmReadFileToImage.3.gz
Error: Orphaned: man/man3/XpmReadFileToPixmap.3.gz
Error: Orphaned: man/man3/XpmReadFileToXpmImage.3.gz
Error: Orphaned: man/man3/XpmWrite.3.gz
Error: Orphaned: man/man3/XpmWriteFileFromBuffer.3.gz
Error: Orphaned: man/man3/XpmWriteFileFromImage.3.gz
Error: Orphaned: man/man3/XpmWriteFileFromPixmap.3.gz
Error: Orphaned: man/man3/XpmWriteFileFromXpmImage.3.gz
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

(In reply to Dimitry Andric from comment #1)
> This also converts the port to USE_GITLAB, since gitlab.com is upstream now.

According to README.md within the distfile, the upstream is
https://gitlab.freedesktop.org/xorg/lib/libXpm , not
https://gitlab.com/libXpm/libXpm which doen't exist, anyway. USE_GITLAB +
GL_COMMIT works fine because USES=xorg-cat:lib adjusts GL_* defaults.

> commit 364b68cacdcf0a95daea5bec9b3d20793c8bea66
> Author: Dimitry Andric <dim@FreeBSD.org>
> Date:   2023-03-26 14:34:10 +0200
> 
>     x11/libXpm: update to 3.5.15

Since ports/ migrated to Git, please, use "git format-patch -1" instead of "git
log -1 -p" when attaching patches on the bugzilla. Otherwise, if anyone else
lands it's hard to preserve correct attribution other than going the old
"Submitted by" style.

> +USE_GITLAB=	yes
> +GL_COMMIT=	ddd8339e262cbb7b25993599299ad40e0c95ccf6

Maybe instead add tar:xz to USES, sorted alphabetically. Besides, it builds
faster without implicit USES=autoreconf.

See also https://gitlab.freedesktop.org/xorg/lib/libXpm/-/commit/fa16fbda9c90

-- 
You are receiving this mail because:
You are the assignee for the bug.