[Bug 233324] x11/libX11: Remove unnecessary perl5 dependency

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 25 Jun 2021 23:16:22 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233324

Michael Gmelin <grembo_at_FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |grembo_at_FreeBSD.org

--- Comment #12 from Michael Gmelin <grembo_at_FreeBSD.org> ---
(In reply to Niclas Zeising from comment #11)

Just looking at this from a non-social perspective.

Jan wrote a year ago:

> The code has clear references:
> - specs/* but the port passes --disable-specs
> - LOG_COMPILER but only used in "make check" (not "make test")

and this still seems to be the case. Build works fine after the change (tried
in a clean environment, "make check" also works from the source directory, but
skips things due to perl not being there[0]). So I can understand from a port
manager perspective why they want to remove the dependency and I don't see how
this change could do any harm. Technically.

This doesn't solve the social question of course.

p.s. If "make check" with all possible tests is wanted in the build, it could
be added as an option that also brings in perl as a build dependency. Right now
it's not exposed in the port skeleton Makefile.

[0]
_at_HAVE_PERL_TRUE_at_LOG_COMPILER = $(PERL)
_at_HAVE_PERL_TRUE_at_TESTS = compose-check.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Fri Jun 25 2021 - 23:16:22 UTC

Original text of this message