From nobody Thu Jan 30 02:44:11 2025 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yk3JC0MLKz5mwVb for ; Thu, 30 Jan 2025 02:44:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yk3JB73qPz3jdy for ; Thu, 30 Jan 2025 02:44:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738205051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZsFJl4Y3U8CDSWKkCA2n9hAtQLC9wWqzNpQOeoGddg=; b=KPEV5/4w56+vHTIk4e0EXnNcAF5yN+Dr2WCfk4GTpDlo8447Gn9H5cx0AIHmPbVWpxRCeA gbKQ4ma+01OimkDpZhoQZxGV/z/fIyTyJmgvoz4ZEnr6pvLfQTmcBWt95yLudKzC569mes L/icYAPpPmhbtSUscm2EAHa3d0EBPH+oiJUkCTx2Fts5YJp3uMU38D1ugaFScc7lqEfRbM XKNHmYN5sB0dmheXgSKcMgR2u6lDSbs9JRLHuT7rQ34l1aLL9bf03gP1sdoW2IOsNiDClz mtAChrgvTpJTLcSkO46jtid5JEos8o00HBO4PCh6cCmglQ7c0EitoAcJ1M/+dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738205051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZsFJl4Y3U8CDSWKkCA2n9hAtQLC9wWqzNpQOeoGddg=; b=A3wkSNtPEYpbFK5pMLM78tXPKh6MlqJU1+Qiv//t7Rq6msSE0QJjcVI+AlvUnhbPh22i9R bgvHcYJSyguRyj5oimOyP1PZs+4+kpARhTGyc0Ng5Ey5srwAc05ccxR3auACNrsUoLmNDL ZQsYigxIgprt/X3BcbAAMYZh5QNGSGGPZM3V6ExmITphkMMdTWPCVz3sqi0sZUgdW+JMky dvXhDjj1+jlLBpvREHrB9QfGs0AcxJagnOlDiHbKqk2sfRyyMlyzzSCfCFbc602q8/acu7 HAyVQyKEwSZzibq+ChQGHr4eOIK5axk20Usv5dyKhVTGX8PDSZLXoRrBR55KcQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738205051; a=rsa-sha256; cv=none; b=ZOm03gUsG2iGe/bVmsCdAeMyOPxh4XdJnVwIWeh9NpKdHnR/Op7I19SouTLhCkRT6GkT5b RH/iAQk5kjGFosKe6M6i2JNl/V7W7SYgE3sZmhpEgMAdNqEa+pC/VWu3IaOsulUy7UKLIZ C1XiklbuwvPsXxY9bbnSAATYjRVls0bN9TlM1O92mrK8NyPVf5xk15RbJ3452bX4TPWw1p CLIVB/I6GsKpn0hHCxI9FtP4YWITSBNx9S16mEP6tCrJ+p8+7zAvSrXLgyUQfLzjM9BHsS 6+S4JI1klfe0TVuq9Kg/aOAp4jJ+cKVFnmo4R7EdqiBmiY/iGURMPGZfE0ChUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yk3JB6YBWzD39 for ; Thu, 30 Jan 2025 02:44:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 50U2iAXv072049 for ; Thu, 30 Jan 2025 02:44:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 50U2iAjL072048 for wireless@FreeBSD.org; Thu, 30 Jan 2025 02:44:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 283903] rtw88: possible skb leak Date: Thu, 30 Jan 2025 02:44:11 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: bz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bz@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-wireless@freebsd.org Sender: owner-freebsd-wireless@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283903 --- Comment #19 from Bjoern A. Zeeb --- So I am currently doing minutely transfers (TX) off the rtw881 instance to another machine. Coming back after a while I see on the 1 minute update differences for vmst= at -m for lkpiskb (but not mbuf-tags): Use: % expr 4071 - 3997 74 Reqs: % expr 17869937 - 17557380 312557 Memory: % expr 54423552 - 54120448 303104 # It's exactly one page a time! % expr 74 \* 4096 303104 The previous logging doesn't catch so it's not that though that's just anot= her error path without an skb free call (there are more in the driver I fixed in the past): I wonder if we are leaking somewhere else inside rtw88 slowly; we should go= and see where skb_allocations are matching a page (like the rsvd page or simila= r). It seems it's a small number (0.023676%). [and while I am writing rtw881 exploded again] rtw881: failed to dequeue 3908 skb TX queue 1, BD=3D0xffffffff, rp 183 -> 4= 095^M rtw881: pci bus timeout, check dma status^M rtw881: pci bus timeout, check dma status^M rtw881: pci bus timeout, check dma status^M [private note from somehwere later in the the trace: WARNING bw > RTW_CHANNEL_WIDTH_40 || nrx >=3D 4 failed at /sys/contrib/dev/rtw88/rtw8822c.c:4412] db> show malloc Type InUse MemUse Requests lkpiskb 3109 49300K 19622568 bounce 8336 33344K 8336 BPF 34 6150K 48 So maybe using dtrace to find allocations with size of a page (4096) would = be interesting to see where they are coming from and how many they are. I'll let that run over night and see in the morning. It's just another hu= nch (the crystal ball currently doesn't seem to work very well). --=20 You are receiving this mail because: You are on the CC list for the bug.=