From nobody Tue Feb 18 05:29:25 2025 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yxp4N62Fjz5p35r for ; Tue, 18 Feb 2025 05:29:40 +0000 (UTC) (envelope-from shuriku@shurik.kiev.ua) Received: from mail.flex-it.com.ua (mail.flex-it.com.ua [193.239.74.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yxp4M1SHMz3VpM for ; Tue, 18 Feb 2025 05:29:39 +0000 (UTC) (envelope-from shuriku@shurik.kiev.ua) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of shuriku@shurik.kiev.ua designates 193.239.74.7 as permitted sender) smtp.mailfrom=shuriku@shurik.kiev.ua Received: from [188.231.181.61] (helo=[10.2.1.107]) by mail.flex-it.com.ua with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.98 (FreeBSD)) (envelope-from ) id 1tkGAl-00000000Hhq-0KeP for wireless@freebsd.org; Tue, 18 Feb 2025 07:29:31 +0200 Content-Type: multipart/alternative; boundary="------------VTDEMby3Jju8XscF29TllEDO" Message-ID: <83f9fff0-d673-4727-977c-0a989dcc7780@shurik.kiev.ua> Date: Tue, 18 Feb 2025 07:29:25 +0200 List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-wireless@freebsd.org Sender: owner-freebsd-wireless@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: iwlwifi / rtw88 / rtw89 hw crypto request for test (precon for HT/VHT) To: wireless@freebsd.org References: Content-Language: uk-UA From: Oleksandr Kryvulia In-Reply-To: X-ACL-Warn: SPF failed. 188.231.181.61 is not allowed to send mail from shurik.kiev.ua. X-Spamd-Result: default: False [-1.07 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997]; NEURAL_SPAM_SHORT(0.55)[0.549]; NEURAL_HAM_LONG(-0.32)[-0.323]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:35297, ipnet:193.239.72.0/22, country:UA]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[wireless@freebsd.org]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_DKIM_NA(0.00)[]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[shurik.kiev.ua]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 4Yxp4M1SHMz3VpM X-Spamd-Bar: - This is a multi-part message in MIME format. --------------VTDEMby3Jju8XscF29TllEDO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 18.02.25 06:01, Bjoern A. Zeeb: > Hi, > > with [1] I added HW_CRYPTO support to the build for all LinuxKPI based > drivers.  This is a pre-condition to make HT/VHT work with drivers/fw > which support, e.g., A-MPDU offloading -- basically almost everything > modern. > > I will very likely MFC it at the end of the week if I didn't put in any > last minute bugs. > > As the commit message says it currently only supports CCMP.  If you > still do WEP or TKIP please let me know and I'll add it to the list > though I'll then likely want your help to test (patches) as well. > > As also mentioned in the commit message I saw one specific panic in the > past which I no longer can reproduce.  I am sure there's some other edge > cases on more devices so I need your help to test. > > While the code is compiled in now it is disabled behind a tunable until > there is sufficient feedback for iwlwifi, rtw88 and rtw89 that it works. > Once that happens I'll flip the default for the tunable at least to on > and eventually remove it alltogether and we can move to the next steps > of testing which is hopefully fully merged to git by then. > > So if you want some HT/VHT to work with at least modern iwlwifi, and then > also older iwlwifi, rtw88 and rtw89 in th enext steps please help testing > and report back the next days. > > To turn the code on add the following line to laoder.conf: >     compat.linuxkpi.80211.hw_crypto=1 > > At runtime you can check the state by using: >     sysctl compat.linuxkpi.80211.hw_crypto > > Also if you have any problems, then you can easily remove that line (or > unset it from loader) and boot with the support turned on. > > If you reply to this thread or me (positive or negative feedback), please > add the pciconf -l line for your wifi card so we known about the chipset. > > > Lots of joy, > Bjoern > > [1] > https://cgit.FreeBSD.org/src/commit/?id=11db70b6057e41b259dc2245cd893d5b19179fcc > Works good, thank you! iwlwifi0@pci0:0:20:3:   class=0x028000 rev=0x01 hdr=0x00 vendor=0x8086 device=0x51f1 subvendor=0x8086 subdevice=0x0090    vendor     = 'Intel Corporation'    device     = 'Raptor Lake PCH CNVi WiFi'    class      = network --------------VTDEMby3Jju8XscF29TllEDO Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
18.02.25 06:01, Bjoern A. Zeeb:
Hi,

with [1] I added HW_CRYPTO support to the build for all LinuxKPI based
drivers.  This is a pre-condition to make HT/VHT work with drivers/fw
which support, e.g., A-MPDU offloading -- basically almost everything
modern.

I will very likely MFC it at the end of the week if I didn't put in any
last minute bugs.

As the commit message says it currently only supports CCMP.  If you
still do WEP or TKIP please let me know and I'll add it to the list
though I'll then likely want your help to test (patches) as well.

As also mentioned in the commit message I saw one specific panic in the
past which I no longer can reproduce.  I am sure there's some other edge
cases on more devices so I need your help to test.

While the code is compiled in now it is disabled behind a tunable until
there is sufficient feedback for iwlwifi, rtw88 and rtw89 that it works.
Once that happens I'll flip the default for the tunable at least to on
and eventually remove it alltogether and we can move to the next steps
of testing which is hopefully fully merged to git by then.

So if you want some HT/VHT to work with at least modern iwlwifi, and then
also older iwlwifi, rtw88 and rtw89 in th enext steps please help testing
and report back the next days.

To turn the code on add the following line to laoder.conf:
    compat.linuxkpi.80211.hw_crypto=1

At runtime you can check the state by using:
    sysctl compat.linuxkpi.80211.hw_crypto

Also if you have any problems, then you can easily remove that line (or
unset it from loader) and boot with the support turned on.

If you reply to this thread or me (positive or negative feedback), please
add the pciconf -l line for your wifi card so we known about the chipset.


Lots of joy,
Bjoern

[1] https://cgit.FreeBSD.org/src/commit/?id=11db70b6057e41b259dc2245cd893d5b19179fcc


Works good, thank you!

iwlwifi0@pci0:0:20:3:   class=0x028000 rev=0x01 hdr=0x00 vendor=0x8086 device=0x51f1 subvendor=0x8086 subdevice=0x0090
   vendor     = 'Intel Corporation'
   device     = 'Raptor Lake PCH CNVi WiFi'
   class      = network

 --------------VTDEMby3Jju8XscF29TllEDO--