From nobody Wed Feb 14 19:50:33 2024 X-Original-To: wireless@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TZphT4Fl7z52hXf for ; Wed, 14 Feb 2024 19:50:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TZphT0g5Nz4lpM for ; Wed, 14 Feb 2024 19:50:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707940233; a=rsa-sha256; cv=none; b=s40t5V9BLmf/CVuJWXfcH1bhUCEbw4+g3Td8fheZpxv0l84+D0B/QzZ7U/uItQ0RBzO3HP EfrLKTmAHUk3b1d6LR4WZP8IlGIxgRSkMOjkkZEB8l7pB11xknCf98ScWbaTU7KD/NAFSB 8FWeEWEQB6hX1Jf8rg3nhCB6CirwT0OokdxcedJ+6TEhXkiRUSdo1ym/w13SyknSy1azvZ JrrgqtNkkMI0J9VDzMfPZz/wSa1F//0ROh6T1XjeaYT3XB2oxk5wSNJr+e5jadp4WK34+i mu3a7OQXT5ya0d+p5/8YA6rW6IEg1FQnoWGMtBOYLId/t0q6yhPEut+LWPgamQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707940233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zHrdAmNeI3TjSUNB7HBp88NU3imeYYFLx+j5wW5AdqM=; b=tEYLSCsdaG8Mbwwzm/JFKt9gvDrwt/IQgk8a7EmsCDRqgLgiOE08/712PgZS831xrgDfbv +cGPNiNtyrBDyxyaKXKyAavRSMaKJhG3cn1Cit9WVgTsFuL4piFjP2hImOuLCB7Gv6VRPW +RfTbMZQ42XpIdSi8kBKfukYtjvFtVCBUrn1fwDkhqEU1cOuXllJT38F7jji1fX98/Wqfj 6AN1yGQ3Rguudih298B1FNy8aGt4k9shty6UQdPXeJFHUxV+5LAfrTHcMfGO2yDNPTpftf Vengxfvl6vHDV4D3pQEkqp1H4j8ia3KPxprBhUTezZmKVKU7m+wvFtPShLHDAA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TZphS6YtHz1B4Z for ; Wed, 14 Feb 2024 19:50:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41EJoWaN046125 for ; Wed, 14 Feb 2024 19:50:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41EJoWGx046123 for wireless@FreeBSD.org; Wed, 14 Feb 2024 19:50:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: wireless@FreeBSD.org Subject: [Bug 275255] iwlwifi: panic after iwlwifi0: lkpi_iv_newstate: error -5 during state transition 5 (RUN) -> 0 (INIT) Date: Wed, 14 Feb 2024 19:50:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: wireless X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: wireless@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-wireless List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-wireless@freebsd.org X-BeenThere: freebsd-wireless@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275255 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D2ac8a2189ac6707f48f77ef2e36baf696= a0d2f40 commit 2ac8a2189ac6707f48f77ef2e36baf696a0d2f40 Author: Bjoern A. Zeeb AuthorDate: 2024-02-03 16:33:56 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-02-14 19:47:53 +0000 LinuxKPI: 802.11: band-aid for invalid state changes after (*iv_update_= bss) With firmware based solutions we cannot just jump from an active session to a new iv_bss node without tearing down state for the old and bringing up the new node. This likely used to work on softmac based cards/drive= rs where one could essentially set the state and fire at will. We track (*iv_update_bss) calls from net80211 and set a local flag that we are out of synch and do not allow any further operations up the state machine until we hit INIT or SCAN. That means someone will take the st= ate down, clean up firmware state and then we can join again and build up state. Apparently this problem has been "known" for a while as native iwm(4) a= nd others have similar workarounds (though less strict) and can be equally pestered into bad states. For LinuxKPI all the KASSERTs just massively brought this problem out. The solution will be some rewrites in net802= 11. Until then, try to keep us more stable at least and not die on second join1() calls triggered by service netif start wlan0 and similar. PR: 271979, 271988, 275255, 263613, 274003 Sponsored by: The FreeBSD Foundation (2023, partial) MFC after: 3 days Reviewed by: cc Differential Revision: https://reviews.freebsd.org/D43725 sys/compat/linuxkpi/common/src/linux_80211.c | 309 +++++++++++++++++++----= ---- sys/compat/linuxkpi/common/src/linux_80211.h | 2 + 2 files changed, 216 insertions(+), 95 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=