From nobody Thu Jan 26 22:36:07 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P2wXm569Zz3cCbs for ; Thu, 26 Jan 2023 22:36:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P2wXm1WZTz4H57 for ; Thu, 26 Jan 2023 22:36:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674772568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aO+aVkF7YSBHEa+ccmAQkfdhNEnVI9mAMmOUrY+EqOU=; b=ULnu3tOW+aCTnGNHUAoCb4M5Z3C9AHToN75zP+gJ2J+/Zjbm41aC3hGOZ+7R+la+SKKltd oB+CJe7HfTGk0JyT0ow81LwT7ZrSgGrtdstnN6cWFRltfUU2nOidGnjBTiDdYl5ob/c75j Y1648/zVvinB18y3acEx/KAW+vVMffmdEDMLaSLjtT7fiySHJkpRFFnOtDohCKmxvftUMJ 5FuewYVmtNGLeYa1vw1m/HUFeOxEJ59BOc9O5kowNUlD0RuLyPxHV2+Zz+SGD5zaIWoO/f jyO7F8reCXkvoH3yBnVqkGJ6+3sZVJJhy9aitRhdlHdaGQJCSoYWGXYCWfM9jw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674772568; a=rsa-sha256; cv=none; b=UAKt8+a/C+iUTttTtce/Duqsq0OjtJtNoT5Ix2YTGrffScPeo8ADViqRVEy/KHyVfopRwd PB0CJRNGi6N5C+Na/4WBBKGq93K2cR3RdAbUjJoMietJ8FJLIut/vUY71QpcG4UVk4XPnc KKDrVtkDtFeVEN9OkA+wGWW/vAmT5PZvHdrDcFZdFBtSOUs1/zSk9xreKWzLH+9XTe4iQN anCgamOh43j/KieMJD6NZFAAtl6KeCtJXaxDZKWB5bq86g6fZe9fJy4clqMtRMVYgpC3af jJJFxzf+HN4H7LtMh3N7xCtc+H5jdvk5rVNIXpPUrygsnvKC8Y74VuFs5IppSg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P2wXl6K5Zzmgd for ; Thu, 26 Jan 2023 22:36:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 30QMa7dE007936 for ; Thu, 26 Jan 2023 22:36:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 30QMa7qD007935 for virtualization@FreeBSD.org; Thu, 26 Jan 2023 22:36:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 264435] bhyve: hda_write() can index (and jump) beyond end of array Date: Thu, 26 Jan 2023 22:36:07 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: needs-patch, needs-qa, security X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: jhb@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264435 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Df31dc54deed4bfc2779a991758033c36a= 9bf6fd1 commit f31dc54deed4bfc2779a991758033c36a9bf6fd1 Author: John Baldwin AuthorDate: 2023-01-20 17:57:45 +0000 Commit: John Baldwin CommitDate: 2023-01-26 22:28:56 +0000 bhyve: Fix a global buffer overread in the PCI hda device model. hda_write did not validate the relative register offset before using it as an index into the hda_set_reg_table array to lookup a function pointer to execute after updating the register's value. PR: 264435 Reported by: Robert Morris Reviewed by: corvink, markj, emaste Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D38127 (cherry picked from commit bfe8e339eb77910c2eb739b45aaa936148b33897) usr.sbin/bhyve/pci_hda.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=