From nobody Fri Jan 20 17:59:59 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nz6hv3rCSz2t8MG for ; Fri, 20 Jan 2023 17:59:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nz6hv0nM8z4Lby for ; Fri, 20 Jan 2023 17:59:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674237599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h9KDhVwid0iODPse0bdp6NA3kapQG1fEMVbLPtXtMus=; b=DDzN55HKLx5qVzhsZutK9Fk3r1Nfkij6Y+nZ2gryopEiI9RV2NnKgoiMpl86xpzjIfYVRx Ci7/HSzN0APJBUoPqGewW08cz8uGJGMmhA6GIFr4ojRAAOFUpbgMfqRk/1nz65MxASERgt Zdl0D2s/NoYhc/bzWTJk21LqP8/kc6H4vSKjFnhc3GZd4QgQgld9qqoNeZEV6sOl+gJImE mqBNzmSrrsVslYIcZW1k8CTXTLAOlvTJrTjs4N/lImGev/cBnapT0cJQh/cxU6tjJ9wRww CwsOIjELDFHe/awpo059Wv6yHlpSmNjiumvfrUQ/5loWUWq0ihC3wK54KQnSwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674237599; a=rsa-sha256; cv=none; b=keJlSKeBauqsyqUWSONW0vr9WjQZJy4A8hufPlkbW3xenrc6eRW7axTT0TOsb0uKRdqrbZ oSMH68O+bbE7CcNrXKHLkKRsBxE3c1EmCIjsrNE7Wcy1zNBKnWxfF8ZBvW1SXgMcWS0kY4 ZPjQ+nijKjAIU/LzCeEDvsrDKT/fKNSOO+UnS8JBpLYykbJYsvhQS5xoYXa2sRD61bFOMM mys9VrK56g4Jti38BTH5Limx1qYqwy6WqIZh/MHVo26VQqgKLHcsO/AiesMD8rOXju5fJM W0iRmPloVFqNCOVI0rBjJX6Fji929W1+0Myb5ebg79LYNz8iDiYh7hp6KPjasA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Nz6ht70kDzffb for ; Fri, 20 Jan 2023 17:59:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 30KHxwoP051413 for ; Fri, 20 Jan 2023 17:59:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 30KHxwnm051412 for virtualization@FreeBSD.org; Fri, 20 Jan 2023 17:59:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 264435] bhyve: hda_write() can index (and jump) beyond end of array Date: Fri, 20 Jan 2023 17:59:59 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: needs-patch, needs-qa, security X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264435 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dbfe8e339eb77910c2eb739b45aaa93614= 8b33897 commit bfe8e339eb77910c2eb739b45aaa936148b33897 Author: John Baldwin AuthorDate: 2023-01-20 17:57:45 +0000 Commit: John Baldwin CommitDate: 2023-01-20 17:57:45 +0000 bhyve: Fix a global buffer overread in the PCI hda device model. hda_write did not validate the relative register offset before using it as an index into the hda_set_reg_table array to lookup a function pointer to execute after updating the register's value. PR: 264435 Reported by: Robert Morris Reviewed by: corvink, markj, emaste Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D38127 usr.sbin/bhyve/pci_hda.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=