From nobody Mon Apr 03 11:26:05 2023 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PqpVv5GNvz444Wf for ; Mon, 3 Apr 2023 11:26:15 +0000 (UTC) (envelope-from SRS0=Xy+K=72=freebsd.org=grehan@iredmail.onthenet.com.au) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PqpVr4TKKz3myT for ; Mon, 3 Apr 2023 11:26:11 +0000 (UTC) (envelope-from SRS0=Xy+K=72=freebsd.org=grehan@iredmail.onthenet.com.au) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=nt.com.au header.s=dkim header.b=HSYMo2Mw; spf=none (mx1.freebsd.org: domain of "SRS0=Xy+K=72=freebsd.org=grehan@iredmail.onthenet.com.au" has no SPF policy when checking 203.13.68.12) smtp.mailfrom="SRS0=Xy+K=72=freebsd.org=grehan@iredmail.onthenet.com.au"; dmarc=none Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) by alto.onthenet.com.au (Postfix) with ESMTPS id 0812920B49EA for ; Mon, 3 Apr 2023 21:26:06 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id EEA3A21419EE for ; Mon, 3 Apr 2023 21:26:05 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nt.com.au; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:references:to:content-language:subject:subject :user-agent:mime-version:date:date:message-id; s=dkim; t= 1680521165; x=1683113166; bh=uBHHZ5byYpTo2txL0NfWw5RtF4myiTfzm09 Vp36u4o0=; b=HSYMo2Mwer9yzQpKiTcClL+vE6DkRghY1K35k2zOLoHa7IDoSUB cKZN7lGEQieD6lNFcF4/Vg78sEoVbzUiN4VGX9LZiZyU8ErmIrsgxUF3cWPmo+zt ct4YVa1pWMoZfC+dKHE69kCrKVm5Qxg+F66AGVM8owsKmGDycnLBM7NY= Received: from iredmail.onthenet.com.au ([127.0.0.1]) by iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 87LCFfnT8n0n for ; Mon, 3 Apr 2023 21:26:05 +1000 (AEST) Received: from [192.168.1.102] (otn-120-29-29-47.broadband.onthenet.net [120.29.29.47]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id C2E4F21419ED; Mon, 3 Apr 2023 21:26:05 +1000 (AEST) Message-ID: Date: Mon, 3 Apr 2023 21:26:05 +1000 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] OvmfPkg/BhyveBhf: install bhyve's ACPI tables Content-Language: en-US To: =?UTF-8?Q?Corvin_K=c3=b6hne?= References: <20230331123936.540020-1-corvink@FreeBSD.org> Cc: virtualization@FreeBSD.org From: Peter Grehan In-Reply-To: <20230331123936.540020-1-corvink@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=fas2N3YF c=1 sm=1 tr=0 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=aPteTwT7mLQc2Z4+GGj7vw==:17 a=IkcTkHD0fZMA:10 a=dKHAf1wccvYA:10 a=wFlrr7yDPfm8kmhmw4sA:9 a=QEXdDO2ut3YA:10 X-Spamd-Result: default: False [-3.20 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[grehan@freebsd.org,SRS0=Xy@iredmail.onthenet.com.au]; R_DKIM_ALLOW(-0.20)[nt.com.au:s=dkim]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[203.13.68.12:from]; RWL_MAILSPIKE_GOOD(-0.10)[203.13.68.12:from]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[grehan@freebsd.org,SRS0=Xy@iredmail.onthenet.com.au]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; PREVIOUSLY_DELIVERED(0.00)[virtualization@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_FROM(0.00)[K=72=freebsd.org=grehan]; R_SPF_NA(0.00)[no SPF record]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[nt.com.au:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:9313, ipnet:203.13.68.0/24, country:AU]; RCVD_TLS_LAST(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[virtualization@FreeBSD.org] X-Rspamd-Queue-Id: 4PqpVr4TKKz3myT X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Hi Corvin, > I would like to send the following patch to the EDKII project. > Therefore, I'd like to get some feedback from the bhyve community before > sending them to EDKII. Thanks for giving a heads-up. The patch looks fine to me. The only minor suggestion I have is to use the qemu fwcfg interface to locate the RSDP instead of searching through memory, since presumably any new ACPI table functionality in bhyve would be after this point in time where qemu fwcfg is already supported. later, Peter.